| From 01100d6436dac14967691643d1f6b4aca7a76fb2 Mon Sep 17 00:00:00 2001 |
| From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> |
| Date: Wed, 4 Jul 2018 11:14:47 +0300 |
| Subject: [PATCH 1576/1795] sh_eth: remove useless serialization in |
| sh_eth_get_link_ksettings() |
| |
| phy_ethtool_ksettings_get() call does not modify device state or device |
| driver state, hence there is no need to utilize a driver specific |
| spinlock. |
| |
| Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> |
| Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit f3146f3774c8657b25326313ce807a5d4eac1d40) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| --- |
| drivers/net/ethernet/renesas/sh_eth.c | 5 ----- |
| 1 file changed, 5 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c |
| index ad8f1d9edf01..1887ae80fa47 100644 |
| --- a/drivers/net/ethernet/renesas/sh_eth.c |
| +++ b/drivers/net/ethernet/renesas/sh_eth.c |
| @@ -2043,15 +2043,10 @@ static int sh_eth_phy_start(struct net_device *ndev) |
| static int sh_eth_get_link_ksettings(struct net_device *ndev, |
| struct ethtool_link_ksettings *cmd) |
| { |
| - struct sh_eth_private *mdp = netdev_priv(ndev); |
| - unsigned long flags; |
| - |
| if (!ndev->phydev) |
| return -ENODEV; |
| |
| - spin_lock_irqsave(&mdp->lock, flags); |
| phy_ethtool_ksettings_get(ndev->phydev, cmd); |
| - spin_unlock_irqrestore(&mdp->lock, flags); |
| |
| return 0; |
| } |
| -- |
| 2.19.0 |
| |
