| From cbe328377241c633b4b543cc0df99ff7483f2ec4 Mon Sep 17 00:00:00 2001 |
| From: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com> |
| Date: Sun, 9 Jun 2013 16:07:28 +0300 |
| Subject: spi: spi-xilinx: cleanup a check in xilinx_spi_txrx_bufs() |
| |
| '!' has higher precedence than comparisons so the original condition |
| is equivalent to "if (xspi->remaining_bytes == 0)". This makes the |
| static checkers complain. |
| |
| xspi->remaining_bytes is signed and from looking at the code |
| briefly, I think it might be able to go negative. I suspect that |
| going negative may cause a bug, but I don't have the hardware and |
| can't test. |
| |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Mark Brown <broonie@linaro.org> |
| (cherry picked from commit e33d085d11e54bc9fb07b2555cd104d8e7b3089b) |
| Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp> |
| Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp> |
| --- |
| drivers/spi/spi-xilinx.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/spi/spi-xilinx.c b/drivers/spi/spi-xilinx.c |
| index a6c475b43dcc..09a942852593 100644 |
| --- a/drivers/spi/spi-xilinx.c |
| +++ b/drivers/spi/spi-xilinx.c |
| @@ -316,7 +316,7 @@ static int xilinx_spi_txrx_bufs(struct spi_device *spi, struct spi_transfer *t) |
| } |
| |
| /* See if there is more data to send */ |
| - if (!xspi->remaining_bytes > 0) |
| + if (xspi->remaining_bytes <= 0) |
| break; |
| } |
| |
| -- |
| 1.8.5.rc3 |
| |
