| From 430a9757ebdaa09122c5f6429e2e791f34a27ec7 Mon Sep 17 00:00:00 2001 |
| From: Jean Delvare <jdelvare@suse.de> |
| Date: Mon, 21 Oct 2013 17:38:49 +0200 |
| Subject: watchdog: Get rid of MODULE_ALIAS_MISCDEV statements |
| |
| I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR) |
| and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements. |
| |
| Either the device is enumerated and the driver already has a module |
| alias (e.g. PCI, USB etc.) that will get the right driver loaded |
| automatically. |
| |
| Or the device is not enumerated and loading its driver will lead to |
| more or less intrusive hardware poking. Such hardware poking should be |
| limited to a bare minimum, so the user should really decide which |
| drivers should be tried and in what order. Trying them all in |
| arbitrary order can't do any good. |
| |
| On top of that, loading that many drivers at once bloats the kernel |
| log. Also many drivers will stay loaded afterward, bloating the output |
| of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets |
| loaded as a dependency) can't even be unloaded! |
| |
| If defining char-major-10-130 is needed then it should happen in |
| user-space. |
| |
| Signed-off-by: Jean Delvare <jdelvare@suse.de> |
| Acked-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Wim Van Sebroeck <wim@iguana.be> |
| Cc: Stephen Warren <swarren@wwwdotorg.org> |
| Cc: Mike Frysinger <vapier.adi@gmail.com> |
| Cc: Wan ZongShun <mcuos.com@gmail.com> |
| Cc: Ben Dooks <ben-linux@fluff.org> |
| Cc: Kukjin Kim <kgene.kim@samsung.com> |
| Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk> |
| Cc: Jim Cromie <jim.cromie@gmail.com> |
| (cherry picked from commit 487722cf2d66126338217896642bd5eec832c34b) |
| Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp> |
| Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp> |
| --- |
| drivers/watchdog/of_xilinx_wdt.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/watchdog/of_xilinx_wdt.c b/drivers/watchdog/of_xilinx_wdt.c |
| index 4dd281f2c33f..fb57103c8ebc 100644 |
| --- a/drivers/watchdog/of_xilinx_wdt.c |
| +++ b/drivers/watchdog/of_xilinx_wdt.c |
| @@ -405,4 +405,3 @@ module_platform_driver(xwdt_driver); |
| MODULE_AUTHOR("Alejandro Cabrera <aldaya@gmail.com>"); |
| MODULE_DESCRIPTION("Xilinx Watchdog driver"); |
| MODULE_LICENSE("GPL v2"); |
| -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); |
| -- |
| 1.8.5.rc3 |
| |
