| From 6e811ed59c47a4fdfefb4cbfc672e9cfd13c3c07 Mon Sep 17 00:00:00 2001 |
| From: Michal Simek <michal.simek@xilinx.com> |
| Date: Thu, 30 May 2013 00:28:03 +0000 |
| Subject: net: emaclite: Report failures in mdio setup |
| |
| Be more verbose when any problem happens. |
| |
| Signed-off-by: Michal Simek <michal.simek@xilinx.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit ccfecdfe16a872ed3e8322ea48e34502568eb849) |
| Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp> |
| Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp> |
| --- |
| drivers/net/ethernet/xilinx/xilinx_emaclite.c | 12 +++++++++--- |
| 1 file changed, 9 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c |
| index b7268b3dae77..1fabaef46d7b 100644 |
| --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c |
| +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c |
| @@ -852,8 +852,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) |
| /* Don't register the MDIO bus if the phy_node or its parent node |
| * can't be found. |
| */ |
| - if (!np) |
| + if (!np) { |
| + dev_err(dev, "Failed to register mdio bus.\n"); |
| return -ENODEV; |
| + } |
| |
| /* Enable the MDIO bus by asserting the enable bit in MDIO Control |
| * register. |
| @@ -862,8 +864,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) |
| XEL_MDIOCTRL_MDIOEN_MASK); |
| |
| bus = mdiobus_alloc(); |
| - if (!bus) |
| + if (!bus) { |
| + dev_err(dev, "Failed to allocal mdiobus\n"); |
| return -ENOMEM; |
| + } |
| |
| of_address_to_resource(np, 0, &res); |
| snprintf(bus->id, MII_BUS_ID_SIZE, "%.8llx", |
| @@ -879,8 +883,10 @@ static int xemaclite_mdio_setup(struct net_local *lp, struct device *dev) |
| lp->mii_bus = bus; |
| |
| rc = of_mdiobus_register(bus, np); |
| - if (rc) |
| + if (rc) { |
| + dev_err(dev, "Failed to register mdio bus.\n"); |
| goto err_register; |
| + } |
| |
| return 0; |
| |
| -- |
| 1.8.5.rc3 |
| |