| From 12d55317a2913a0a69065cca3de3b9b867338d1b Mon Sep 17 00:00:00 2001 |
| From: Jingoo Han <jg1.han@samsung.com> |
| Date: Tue, 13 May 2014 10:51:58 +0900 |
| Subject: i2c: remove unnecessary OOM messages |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| The site-specific OOM messages are unnecessary, because they |
| duplicate the MM subsystem generic OOM message. For example, |
| k.alloc and v.alloc failures use dump_stack(). |
| |
| Signed-off-by: Jingoo Han <jg1.han@samsung.com> |
| Acked-by: Guenter Roeck <linux@roeck-us.net> |
| Reviewed-by: Jean Delvare <jdelvare@suse.de> |
| Acked-by: Uwe Kleine-Kรถnig <u.kleine-koenig@pengutronix.de> |
| Acked-by: Felipe Balbi <balbi@ti.com> |
| Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Acked-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Wolfram Sang <wsa@the-dreams.de> |
| (cherry picked from commit 46797a2adbf0cdc3be17707dc64e872eeed86a8a) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| |
| Conflicts: |
| drivers/i2c/busses/i2c-efm32.c |
| --- |
| drivers/i2c/busses/i2c-bcm2835.c | 4 +--- |
| drivers/i2c/busses/i2c-diolan-u2c.c | 1 - |
| drivers/i2c/busses/i2c-eg20t.c | 4 +--- |
| drivers/i2c/busses/i2c-exynos5.c | 4 +--- |
| drivers/i2c/busses/i2c-imx.c | 4 +--- |
| drivers/i2c/busses/i2c-omap.c | 4 +--- |
| drivers/i2c/busses/i2c-rcar.c | 4 +--- |
| drivers/i2c/busses/i2c-s3c2410.c | 8 ++------ |
| drivers/i2c/busses/i2c-simtec.c | 4 +--- |
| drivers/i2c/busses/i2c-sirf.c | 1 - |
| drivers/i2c/busses/i2c-stu300.c | 4 +--- |
| drivers/i2c/busses/i2c-tegra.c | 4 +--- |
| drivers/i2c/busses/i2c-wmt.c | 4 +--- |
| drivers/i2c/busses/scx200_acb.c | 4 +--- |
| 14 files changed, 13 insertions(+), 41 deletions(-) |
| |
| diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c |
| index 77df97b932af..9d7d1cdf6abe 100644 |
| --- a/drivers/i2c/busses/i2c-bcm2835.c |
| +++ b/drivers/i2c/busses/i2c-bcm2835.c |
| @@ -225,10 +225,8 @@ static int bcm2835_i2c_probe(struct platform_device *pdev) |
| struct i2c_adapter *adap; |
| |
| i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL); |
| - if (!i2c_dev) { |
| - dev_err(&pdev->dev, "Cannot allocate i2c_dev\n"); |
| + if (!i2c_dev) |
| return -ENOMEM; |
| - } |
| platform_set_drvdata(pdev, i2c_dev); |
| i2c_dev->dev = &pdev->dev; |
| init_completion(&i2c_dev->completion); |
| diff --git a/drivers/i2c/busses/i2c-diolan-u2c.c b/drivers/i2c/busses/i2c-diolan-u2c.c |
| index 721f7ebf9a3b..b19a310bf9b3 100644 |
| --- a/drivers/i2c/busses/i2c-diolan-u2c.c |
| +++ b/drivers/i2c/busses/i2c-diolan-u2c.c |
| @@ -455,7 +455,6 @@ static int diolan_u2c_probe(struct usb_interface *interface, |
| /* allocate memory for our device state and initialize it */ |
| dev = kzalloc(sizeof(*dev), GFP_KERNEL); |
| if (dev == NULL) { |
| - dev_err(&interface->dev, "no memory for device state\n"); |
| ret = -ENOMEM; |
| goto error; |
| } |
| diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c |
| index e08e458bab02..26ca8c7e133d 100644 |
| --- a/drivers/i2c/busses/i2c-eg20t.c |
| +++ b/drivers/i2c/busses/i2c-eg20t.c |
| @@ -751,10 +751,8 @@ static int pch_i2c_probe(struct pci_dev *pdev, |
| pch_pci_dbg(pdev, "Entered.\n"); |
| |
| adap_info = kzalloc((sizeof(struct adapter_info)), GFP_KERNEL); |
| - if (adap_info == NULL) { |
| - pch_pci_err(pdev, "Memory allocation FAILED\n"); |
| + if (adap_info == NULL) |
| return -ENOMEM; |
| - } |
| |
| ret = pci_enable_device(pdev); |
| if (ret) { |
| diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c |
| index 9fd711c03dd2..6fcc0b288fc4 100644 |
| --- a/drivers/i2c/busses/i2c-exynos5.c |
| +++ b/drivers/i2c/busses/i2c-exynos5.c |
| @@ -621,10 +621,8 @@ static int exynos5_i2c_probe(struct platform_device *pdev) |
| int ret; |
| |
| i2c = devm_kzalloc(&pdev->dev, sizeof(struct exynos5_i2c), GFP_KERNEL); |
| - if (!i2c) { |
| - dev_err(&pdev->dev, "no memory for state\n"); |
| + if (!i2c) |
| return -ENOMEM; |
| - } |
| |
| if (of_property_read_u32(np, "clock-frequency", &op_clock)) { |
| i2c->speed_mode = HSI2C_FAST_SPD; |
| diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c |
| index db895fb22e65..584e002fa252 100644 |
| --- a/drivers/i2c/busses/i2c-imx.c |
| +++ b/drivers/i2c/busses/i2c-imx.c |
| @@ -617,10 +617,8 @@ static int i2c_imx_probe(struct platform_device *pdev) |
| |
| i2c_imx = devm_kzalloc(&pdev->dev, sizeof(struct imx_i2c_struct), |
| GFP_KERNEL); |
| - if (!i2c_imx) { |
| - dev_err(&pdev->dev, "can't allocate interface\n"); |
| + if (!i2c_imx) |
| return -ENOMEM; |
| - } |
| |
| if (of_id) |
| i2c_imx->hwdata = of_id->data; |
| diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c |
| index 90dcc2eaac5f..fe9ee696ac49 100644 |
| --- a/drivers/i2c/busses/i2c-omap.c |
| +++ b/drivers/i2c/busses/i2c-omap.c |
| @@ -1114,10 +1114,8 @@ omap_i2c_probe(struct platform_device *pdev) |
| } |
| |
| dev = devm_kzalloc(&pdev->dev, sizeof(struct omap_i2c_dev), GFP_KERNEL); |
| - if (!dev) { |
| - dev_err(&pdev->dev, "Menory allocation failed\n"); |
| + if (!dev) |
| return -ENOMEM; |
| - } |
| |
| mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| dev->base = devm_ioremap_resource(&pdev->dev, mem); |
| diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c |
| index 71e88d055500..899405923678 100644 |
| --- a/drivers/i2c/busses/i2c-rcar.c |
| +++ b/drivers/i2c/busses/i2c-rcar.c |
| @@ -509,10 +509,8 @@ static int rcar_i2c_probe(struct platform_device *pdev) |
| int irq, ret; |
| |
| priv = devm_kzalloc(dev, sizeof(struct rcar_i2c_priv), GFP_KERNEL); |
| - if (!priv) { |
| - dev_err(dev, "no mem for private data\n"); |
| + if (!priv) |
| return -ENOMEM; |
| - } |
| |
| priv->clk = devm_clk_get(dev, NULL); |
| if (IS_ERR(priv->clk)) { |
| diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c |
| index 93ec37649346..5e74249dbd13 100644 |
| --- a/drivers/i2c/busses/i2c-s3c2410.c |
| +++ b/drivers/i2c/busses/i2c-s3c2410.c |
| @@ -1085,16 +1085,12 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) |
| } |
| |
| i2c = devm_kzalloc(&pdev->dev, sizeof(struct s3c24xx_i2c), GFP_KERNEL); |
| - if (!i2c) { |
| - dev_err(&pdev->dev, "no memory for state\n"); |
| + if (!i2c) |
| return -ENOMEM; |
| - } |
| |
| i2c->pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL); |
| - if (!i2c->pdata) { |
| - dev_err(&pdev->dev, "no memory for platform data\n"); |
| + if (!i2c->pdata) |
| return -ENOMEM; |
| - } |
| |
| i2c->quirks = s3c24xx_get_device_quirks(pdev); |
| if (pdata) |
| diff --git a/drivers/i2c/busses/i2c-simtec.c b/drivers/i2c/busses/i2c-simtec.c |
| index 294c80f21d65..964e5c6f84ab 100644 |
| --- a/drivers/i2c/busses/i2c-simtec.c |
| +++ b/drivers/i2c/busses/i2c-simtec.c |
| @@ -77,10 +77,8 @@ static int simtec_i2c_probe(struct platform_device *dev) |
| int ret; |
| |
| pd = kzalloc(sizeof(struct simtec_i2c_data), GFP_KERNEL); |
| - if (pd == NULL) { |
| - dev_err(&dev->dev, "cannot allocate private data\n"); |
| + if (pd == NULL) |
| return -ENOMEM; |
| - } |
| |
| platform_set_drvdata(dev, pd); |
| |
| diff --git a/drivers/i2c/busses/i2c-sirf.c b/drivers/i2c/busses/i2c-sirf.c |
| index 6784f7f527a4..02556c0ff27a 100644 |
| --- a/drivers/i2c/busses/i2c-sirf.c |
| +++ b/drivers/i2c/busses/i2c-sirf.c |
| @@ -307,7 +307,6 @@ static int i2c_sirfsoc_probe(struct platform_device *pdev) |
| |
| siic = devm_kzalloc(&pdev->dev, sizeof(*siic), GFP_KERNEL); |
| if (!siic) { |
| - dev_err(&pdev->dev, "Can't allocate driver data\n"); |
| err = -ENOMEM; |
| goto out; |
| } |
| diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-stu300.c |
| index 5b80ef310841..dc57a16c0e73 100644 |
| --- a/drivers/i2c/busses/i2c-stu300.c |
| +++ b/drivers/i2c/busses/i2c-stu300.c |
| @@ -868,10 +868,8 @@ static int stu300_probe(struct platform_device *pdev) |
| int ret = 0; |
| |
| dev = devm_kzalloc(&pdev->dev, sizeof(struct stu300_dev), GFP_KERNEL); |
| - if (!dev) { |
| - dev_err(&pdev->dev, "could not allocate device struct\n"); |
| + if (!dev) |
| return -ENOMEM; |
| - } |
| |
| bus_nr = pdev->id; |
| dev->clk = devm_clk_get(&pdev->dev, NULL); |
| diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c |
| index 9704537aee3c..8f6f1e4141c1 100644 |
| --- a/drivers/i2c/busses/i2c-tegra.c |
| +++ b/drivers/i2c/busses/i2c-tegra.c |
| @@ -732,10 +732,8 @@ static int tegra_i2c_probe(struct platform_device *pdev) |
| } |
| |
| i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL); |
| - if (!i2c_dev) { |
| - dev_err(&pdev->dev, "Could not allocate struct tegra_i2c_dev"); |
| + if (!i2c_dev) |
| return -ENOMEM; |
| - } |
| |
| i2c_dev->base = base; |
| i2c_dev->div_clk = div_clk; |
| diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c |
| index 2c8a3e4f9008..889a212b6c3d 100644 |
| --- a/drivers/i2c/busses/i2c-wmt.c |
| +++ b/drivers/i2c/busses/i2c-wmt.c |
| @@ -379,10 +379,8 @@ static int wmt_i2c_probe(struct platform_device *pdev) |
| u32 clk_rate; |
| |
| i2c_dev = devm_kzalloc(&pdev->dev, sizeof(*i2c_dev), GFP_KERNEL); |
| - if (!i2c_dev) { |
| - dev_err(&pdev->dev, "device memory allocation failed\n"); |
| + if (!i2c_dev) |
| return -ENOMEM; |
| - } |
| |
| res = platform_get_resource(pdev, IORESOURCE_MEM, 0); |
| i2c_dev->base = devm_ioremap_resource(&pdev->dev, res); |
| diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c |
| index 2d1d2c5653fb..99d6bb3f9d3f 100644 |
| --- a/drivers/i2c/busses/scx200_acb.c |
| +++ b/drivers/i2c/busses/scx200_acb.c |
| @@ -431,10 +431,8 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text, |
| struct i2c_adapter *adapter; |
| |
| iface = kzalloc(sizeof(*iface), GFP_KERNEL); |
| - if (!iface) { |
| - pr_err("can't allocate memory\n"); |
| + if (!iface) |
| return NULL; |
| - } |
| |
| adapter = &iface->adapter; |
| i2c_set_adapdata(adapter, iface); |
| -- |
| 2.1.2 |
| |