| From 459435b1ce52be8b55bb41f803f1f26a9554d183 Mon Sep 17 00:00:00 2001 |
| From: Lars-Peter Clausen <lars@metafoo.de> |
| Date: Sun, 17 Aug 2014 16:18:19 +0200 |
| Subject: ASoC: rcar: Use && instead of & for boolean expressions |
| |
| Sparse spits out the following warning: |
| sound/soc/sh/rcar/gen.c:250:21: warning: dubious: x & !y |
| |
| It does this because sometimes mixing boolean and bit-wise logic has not the |
| intended result. In this case we are fine, but replacing the bit-wise '&' with |
| the boolean '&&' silences the sparse warning. The generated code for both cases |
| is the same. |
| |
| Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> |
| Signed-off-by: Mark Brown <broonie@linaro.org> |
| (cherry picked from commit c8e6e960733f4a5835265c15429fced4d2f1595e) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| sound/soc/sh/rcar/gen.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/sh/rcar/gen.c b/sound/soc/sh/rcar/gen.c |
| index 3fdf3be7b99a..f95e7ab135e8 100644 |
| --- a/sound/soc/sh/rcar/gen.c |
| +++ b/sound/soc/sh/rcar/gen.c |
| @@ -247,7 +247,7 @@ rsnd_gen2_dma_addr(struct rsnd_priv *priv, |
| }; |
| |
| /* it shouldn't happen */ |
| - if (use_dvc & !use_src) |
| + if (use_dvc && !use_src) |
| dev_err(dev, "DVC is selected without SRC\n"); |
| |
| /* use SSIU or SSI ? */ |
| -- |
| 2.1.2 |
| |
