| From dfb59febd3e731b2dabb46135491cde31105e13f Mon Sep 17 00:00:00 2001 |
| From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Date: Wed, 29 Apr 2015 16:54:39 -0300 |
| Subject: [PATCH 262/326] [media] v4l: vsp1: Fix race condition when stopping |
| pipeline |
| |
| When stopping the pipeline the driver waits for the pipeline state to be |
| set to VSP1_PIPELINE_STOPPED but fails to lock the pipe irqlock to read |
| the state variable protected by the lock. Fix it. |
| |
| Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com> |
| (cherry picked from commit 1c991fee30c72ff49bb96558d5f1c14a60230677) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/media/platform/vsp1/vsp1_video.c | 17 ++++++++++++++--- |
| 1 file changed, 14 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c |
| index c4b06214b6c1..c1b5a09b8331 100644 |
| --- a/drivers/media/platform/vsp1/vsp1_video.c |
| +++ b/drivers/media/platform/vsp1/vsp1_video.c |
| @@ -514,6 +514,18 @@ static void vsp1_pipeline_run(struct vsp1_pipeline *pipe) |
| pipe->buffers_ready = 0; |
| } |
| |
| +bool vsp1_pipeline_stopped(struct vsp1_pipeline *pipe) |
| +{ |
| + unsigned long flags; |
| + bool stopped; |
| + |
| + spin_lock_irqsave(&pipe->irqlock, flags); |
| + stopped = pipe->state == VSP1_PIPELINE_STOPPED, |
| + spin_unlock_irqrestore(&pipe->irqlock, flags); |
| + |
| + return stopped; |
| +} |
| + |
| static int vsp1_pipeline_stop(struct vsp1_pipeline *pipe) |
| { |
| struct vsp1_entity *entity; |
| @@ -525,7 +537,7 @@ static int vsp1_pipeline_stop(struct vsp1_pipeline *pipe) |
| pipe->state = VSP1_PIPELINE_STOPPING; |
| spin_unlock_irqrestore(&pipe->irqlock, flags); |
| |
| - ret = wait_event_timeout(pipe->wq, pipe->state == VSP1_PIPELINE_STOPPED, |
| + ret = wait_event_timeout(pipe->wq, vsp1_pipeline_stopped(pipe), |
| msecs_to_jiffies(500)); |
| ret = ret == 0 ? -ETIMEDOUT : 0; |
| |
| @@ -741,8 +753,7 @@ void vsp1_pipelines_suspend(struct vsp1_device *vsp1) |
| if (pipe == NULL) |
| continue; |
| |
| - ret = wait_event_timeout(pipe->wq, |
| - pipe->state == VSP1_PIPELINE_STOPPED, |
| + ret = wait_event_timeout(pipe->wq, vsp1_pipeline_stopped(pipe), |
| msecs_to_jiffies(500)); |
| if (ret == 0) |
| dev_warn(vsp1->dev, "pipeline %u stop timeout\n", |
| -- |
| 2.6.2 |
| |