| From akpm@linux-foundation.org Mon Mar 26 23:00:38 2007 |
| From: akpm@linux-foundation.org |
| Date: Mon, 26 Mar 2007 22:00:28 -0800 |
| Subject: USB: whiteheat: Convert to generic boolean |
| To: greg@kroah.com |
| Cc: akpm@linux-foundation.org, ricknu-0@student.ltu.se, stuartm@connecttech.com |
| Message-ID: <200703270600.l2R60SpK008785@shell0.pdx.osdl.net> |
| |
| |
| From: Richard Knutsson <ricknu-0@student.ltu.se> |
| |
| Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se> |
| Acked-by: Stuart MacDonald <stuartm@connecttech.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/usb/serial/whiteheat.c | 8 ++++---- |
| drivers/usb/serial/whiteheat.h | 4 ---- |
| 2 files changed, 4 insertions(+), 8 deletions(-) |
| |
| --- a/drivers/usb/serial/whiteheat.c |
| +++ b/drivers/usb/serial/whiteheat.c |
| @@ -1109,7 +1109,7 @@ static int firm_send_command (struct usb |
| command_port = port->serial->port[COMMAND_PORT]; |
| command_info = usb_get_serial_port_data(command_port); |
| spin_lock_irqsave(&command_info->lock, flags); |
| - command_info->command_finished = FALSE; |
| + command_info->command_finished = false; |
| |
| transfer_buffer = (__u8 *)command_port->write_urb->transfer_buffer; |
| transfer_buffer[0] = command; |
| @@ -1124,12 +1124,12 @@ static int firm_send_command (struct usb |
| spin_unlock_irqrestore(&command_info->lock, flags); |
| |
| /* wait for the command to complete */ |
| - wait_event_interruptible_timeout(command_info->wait_command, |
| - (command_info->command_finished != FALSE), COMMAND_TIMEOUT); |
| + wait_event_interruptible_timeout(command_info->wait_command, |
| + (bool)command_info->command_finished, COMMAND_TIMEOUT); |
| |
| spin_lock_irqsave(&command_info->lock, flags); |
| |
| - if (command_info->command_finished == FALSE) { |
| + if (command_info->command_finished == false) { |
| dbg("%s - command timed out.", __FUNCTION__); |
| retval = -ETIMEDOUT; |
| goto exit; |
| --- a/drivers/usb/serial/whiteheat.h |
| +++ b/drivers/usb/serial/whiteheat.h |
| @@ -20,10 +20,6 @@ |
| #define __LINUX_USB_SERIAL_WHITEHEAT_H |
| |
| |
| -#define FALSE 0 |
| -#define TRUE 1 |
| - |
| - |
| /* WhiteHEAT commands */ |
| #define WHITEHEAT_OPEN 1 /* open the port */ |
| #define WHITEHEAT_CLOSE 2 /* close the port */ |