commit 1f1b1c633ad952ea13eb36a09c6edb4748967d07
author Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> Wed Oct 22 19:41:29 2008 +0200
committer Greg Kroah-Hartman <gregkh@suse.de> Mon Nov 10 10:50:08 2008 -0800
tree 483f7ca2dcf41d0cd2e5324716ad6d349753ca21
parent 78d7a1672fd0191d0acd079015133da2a62f7439

netfilter: snmp nat leaks memory in case of failure

netfilter: snmp nat leaks memory in case of failure

Upstream commit 311670f3e:

Signed-off-by: Ilpo Jarvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: Patrick McHardy <kaber@trash.net>

net/ipv4/netfilter/nf_nat_snmp_basic.c

diff --git a/net/ipv4/netfilter/nf_nat_snmp_basic.c b/net/ipv4/netfilter/nf_nat_snmp_basic.c
index 8e4148d..1b0a738 100644
--- a/net/ipv4/netfilter/nf_nat_snmp_basic.c
+++ b/net/ipv4/netfilter/nf_nat_snmp_basic.c
@@ -742,6 +742,7 @@
 			*obj = kmalloc(sizeof(struct snmp_object) + len,
 				       GFP_ATOMIC);
 			if (*obj == NULL) {
+				kfree(p);
 				kfree(id);
 				if (net_ratelimit())
 					printk("OOM in bsalg (%d)\n", __LINE__);