commit 64a817cfbded8674f345d1117b117f942a351a69
author J. Bruce Fields <bfields@redhat.com> Tue Mar 26 14:11:13 2013 -0400
committer J. Bruce Fields <bfields@redhat.com> Tue Mar 26 16:18:27 2013 -0400
tree 0095ce868b0da2305045cedfdd8ead602aa12f72
parent e49dbbf3e770aa590a8a464ac4978a09027060b9

nfsd4: reject "negative" acl lengths

Since we only enforce an upper bound, not a lower bound, a "negative"
length can get through here.

The symptom seen was a warning when we attempt to a kmalloc with an
excessive size.

Reported-by: Toralf Förster <toralf.foerster@gmx.de>
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

fs/nfsd/nfs4xdr.c

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 0116886..a272007 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -264,7 +264,7 @@
 		iattr->ia_valid |= ATTR_SIZE;
 	}
 	if (bmval[0] & FATTR4_WORD0_ACL) {
-		int nace;
+		u32 nace;
 		struct nfs4_ace *ace;
 
 		READ_BUF(4); len += 4;