| From 8040835760adf0ef66876c063d47f79f015fb55d Mon Sep 17 00:00:00 2001 |
| From: Vasiliy Kulikov <segoon@openwall.com> |
| Date: Fri, 4 Feb 2011 15:23:59 +0300 |
| Subject: platform: x86: asus_acpi: world-writable procfs files |
| |
| From: Vasiliy Kulikov <segoon@openwall.com> |
| |
| commit 8040835760adf0ef66876c063d47f79f015fb55d upstream. |
| |
| Don't allow everybody to change ACPI settings. The comment says that it |
| is done deliberatelly, however, the comment before disp_proc_write() |
| says that at least one of these setting is experimental. |
| |
| Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> |
| Signed-off-by: Matthew Garrett <mjg@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/platform/x86/asus_acpi.c | 8 +------- |
| 1 file changed, 1 insertion(+), 7 deletions(-) |
| |
| --- a/drivers/platform/x86/asus_acpi.c |
| +++ b/drivers/platform/x86/asus_acpi.c |
| @@ -1001,14 +1001,8 @@ static int asus_hotk_add_fs(struct acpi_ |
| struct proc_dir_entry *proc; |
| mode_t mode; |
| |
| - /* |
| - * If parameter uid or gid is not changed, keep the default setting for |
| - * our proc entries (-rw-rw-rw-) else, it means we care about security, |
| - * and then set to -rw-rw---- |
| - */ |
| - |
| if ((asus_uid == 0) && (asus_gid == 0)) { |
| - mode = S_IFREG | S_IRUGO | S_IWUGO; |
| + mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP; |
| } else { |
| mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP; |
| printk(KERN_WARNING " asus_uid and asus_gid parameters are " |
