| From 6960f40a954619857e7095a6179eef896f297077 Mon Sep 17 00:00:00 2001 |
| From: Jiri Slaby <jslaby@suse.cz> |
| Date: Mon, 28 Feb 2011 10:34:06 +0100 |
| Subject: USB: serial/kobil_sct, fix potential tty NULL dereference |
| |
| From: Jiri Slaby <jslaby@suse.cz> |
| |
| commit 6960f40a954619857e7095a6179eef896f297077 upstream. |
| |
| Make sure that we check the return value of tty_port_tty_get. |
| Sometimes it may return NULL and we later dereference that. |
| |
| The only place here is in kobil_read_int_callback, so fix it. |
| |
| Signed-off-by: Jiri Slaby <jslaby@suse.cz> |
| Cc: Alan Cox <alan@linux.intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/usb/serial/kobil_sct.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/usb/serial/kobil_sct.c |
| +++ b/drivers/usb/serial/kobil_sct.c |
| @@ -372,7 +372,7 @@ static void kobil_read_int_callback(stru |
| } |
| |
| tty = tty_port_tty_get(&port->port); |
| - if (urb->actual_length) { |
| + if (tty && urb->actual_length) { |
| |
| /* BEGIN DEBUG */ |
| /* |
