| From 812eb258311f89bcd664a34a620f249d54a2cd83 Mon Sep 17 00:00:00 2001 |
| From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> |
| Date: Tue, 31 May 2011 08:40:40 +0300 |
| Subject: UBIFS: fix memory leak on error path |
| |
| From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> |
| |
| commit 812eb258311f89bcd664a34a620f249d54a2cd83 upstream. |
| |
| UBIFS leaks memory on error path in 'ubifs_jnl_update()' in case of write |
| failure because it forgets to free the 'struct ubifs_dent_node *dent' object. |
| Although the object is small, the alignment can make it large - e.g., 2KiB |
| if the min. I/O unit is 2KiB. |
| |
| Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| fs/ubifs/journal.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/fs/ubifs/journal.c |
| +++ b/fs/ubifs/journal.c |
| @@ -665,6 +665,7 @@ out_free: |
| |
| out_release: |
| release_head(c, BASEHD); |
| + kfree(dent); |
| out_ro: |
| ubifs_ro_mode(c, err); |
| if (last_reference) |
