| From 472b91274a6c6857877b5caddb875dcb5ecdfcb8 Mon Sep 17 00:00:00 2001 |
| From: Felipe Balbi <balbi@ti.com> |
| Date: Fri, 13 May 2011 16:53:48 +0300 |
| Subject: usb: gadget: rndis: don't test against req->length |
| |
| From: Felipe Balbi <balbi@ti.com> |
| |
| commit 472b91274a6c6857877b5caddb875dcb5ecdfcb8 upstream. |
| |
| composite.c always sets req->length to zero |
| and expects function driver's setup handlers |
| to return the amount of bytes to be used |
| on req->length. If we test against req->length |
| w_length will always be greater than req->length |
| thus making us always stall that particular |
| SEND_ENCAPSULATED_COMMAND request. |
| |
| Tested against a Windows XP SP3. |
| |
| Signed-off-by: Felipe Balbi <balbi@ti.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/usb/gadget/f_rndis.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/drivers/usb/gadget/f_rndis.c |
| +++ b/drivers/usb/gadget/f_rndis.c |
| @@ -419,8 +419,7 @@ rndis_setup(struct usb_function *f, cons |
| */ |
| case ((USB_DIR_OUT | USB_TYPE_CLASS | USB_RECIP_INTERFACE) << 8) |
| | USB_CDC_SEND_ENCAPSULATED_COMMAND: |
| - if (w_length > req->length || w_value |
| - || w_index != rndis->ctrl_id) |
| + if (w_value || w_index != rndis->ctrl_id) |
| goto invalid; |
| /* read the request; process it later */ |
| value = w_length; |