| From d83a040b8a8b34e8fa6f7858533a5964e92f4b87 Mon Sep 17 00:00:00 2001 |
| From: Geert Uytterhoeven <geert+renesas@glider.be> |
| Date: Thu, 18 May 2017 15:01:35 +0200 |
| Subject: [PATCH 113/286] sh_eth: Do not print an error message for probe |
| deferral |
| |
| EPROBE_DEFER is not an error, hence printing an error message like |
| |
| sh-eth ee700000.ethernet: failed to initialise MDIO |
| |
| may confuse the user. |
| |
| To fix this, suppress the error message in case of probe deferral. |
| While at it, shorten the message, and add the actual error code. |
| |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit b7ce520e9f71ff65d0aa0ad86223f94ae4095fae) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/net/ethernet/renesas/sh_eth.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/renesas/sh_eth.c |
| +++ b/drivers/net/ethernet/renesas/sh_eth.c |
| @@ -3222,7 +3222,8 @@ static int sh_eth_drv_probe(struct platf |
| /* MDIO bus init */ |
| ret = sh_mdio_init(mdp, pd); |
| if (ret) { |
| - dev_err(&pdev->dev, "failed to initialise MDIO\n"); |
| + if (ret != -EPROBE_DEFER) |
| + dev_err(&pdev->dev, "MDIO init failed: %d\n", ret); |
| goto out_release; |
| } |
| |
