| From 5ba3522b63be99e95e6aa4e1dfaae4143db04ea9 Mon Sep 17 00:00:00 2001 |
| From: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> |
| Date: Wed, 8 Feb 2017 18:31:14 +0100 |
| Subject: [PATCH 234/255] serial: sh-sci: fix hardware RX trigger level setting |
| |
| 1. Do not set the RX trigger level for software timeout devices on reset; |
| there is no timeout by default, and data will rot. |
| 2. Do set the RX trigger level for hardware timeout devices when set |
| via sysfs attribute. |
| |
| Fixes SCIFA-type serial consoles. |
| |
| Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com> |
| Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| (cherry picked from commit 90afa5255f5c5ae67c869918e4c5f60b8580db70) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/tty/serial/sh-sci.c | 11 +++++++++-- |
| 1 file changed, 9 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/tty/serial/sh-sci.c |
| +++ b/drivers/tty/serial/sh-sci.c |
| @@ -1076,8 +1076,11 @@ static ssize_t rx_trigger_store(struct d |
| |
| if (kstrtol(buf, 0, &r) == -EINVAL) |
| return -EINVAL; |
| + |
| sci->rx_trigger = scif_set_rtrg(port, r); |
| - scif_set_rtrg(port, 1); |
| + if (port->type == PORT_SCIFA || port->type == PORT_SCIFB) |
| + scif_set_rtrg(port, 1); |
| + |
| return count; |
| } |
| |
| @@ -2181,7 +2184,11 @@ static void sci_reset(struct uart_port * |
| setup_timer(&s->rx_fifo_timer, rx_fifo_timer_fn, |
| (unsigned long)s); |
| } else { |
| - scif_set_rtrg(port, s->rx_trigger); |
| + if (port->type == PORT_SCIFA || |
| + port->type == PORT_SCIFB) |
| + scif_set_rtrg(port, 1); |
| + else |
| + scif_set_rtrg(port, s->rx_trigger); |
| } |
| } |
| } |