| From b845f6e9f70e2a0e1008d9238e19e4305f780d04 Mon Sep 17 00:00:00 2001 |
| From: Michal Simek <michal.simek@xilinx.com> |
| Date: Thu, 10 Oct 2013 08:30:21 +0200 |
| Subject: video: xilinxfb: Use devm_kzalloc instead of kzalloc |
| |
| Simplify driver probe and release function. |
| |
| Signed-off-by: Michal Simek <michal.simek@xilinx.com> |
| Reviewed-by: Jingoo Han <jg1.han@samsung.com> |
| Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> |
| (cherry picked from commit 5c128df7471a6917f84cde3cea786541aaa404a2) |
| Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp> |
| Signed-off-by: Yoshitake Kobayashi <yoshitake.kobayashi@toshiba.co.jp> |
| --- |
| drivers/video/xilinxfb.c | 11 ++--------- |
| 1 file changed, 2 insertions(+), 9 deletions(-) |
| |
| diff --git a/drivers/video/xilinxfb.c b/drivers/video/xilinxfb.c |
| index d12345f7fca4..c420328afb40 100644 |
| --- a/drivers/video/xilinxfb.c |
| +++ b/drivers/video/xilinxfb.c |
| @@ -368,8 +368,6 @@ err_fbmem: |
| devm_iounmap(dev, drvdata->regs); |
| |
| err_region: |
| - kfree(drvdata); |
| - |
| return rc; |
| } |
| |
| @@ -402,8 +400,6 @@ static int xilinxfb_release(struct device *dev) |
| dcr_unmap(drvdata->dcr_host, drvdata->dcr_len); |
| #endif |
| |
| - kfree(drvdata); |
| - |
| return 0; |
| } |
| |
| @@ -423,11 +419,9 @@ static int xilinxfb_of_probe(struct platform_device *pdev) |
| pdata = xilinx_fb_default_pdata; |
| |
| /* Allocate the driver data region */ |
| - drvdata = kzalloc(sizeof(*drvdata), GFP_KERNEL); |
| - if (!drvdata) { |
| - dev_err(&pdev->dev, "Couldn't allocate device private record\n"); |
| + drvdata = devm_kzalloc(&pdev->dev, sizeof(*drvdata), GFP_KERNEL); |
| + if (!drvdata) |
| return -ENOMEM; |
| - } |
| |
| /* |
| * To check whether the core is connected directly to DCR or BUS |
| @@ -451,7 +445,6 @@ static int xilinxfb_of_probe(struct platform_device *pdev) |
| drvdata->dcr_host = dcr_map(op->dev.of_node, start, drvdata->dcr_len); |
| if (!DCR_MAP_OK(drvdata->dcr_host)) { |
| dev_err(&op->dev, "invalid DCR address\n"); |
| - kfree(drvdata); |
| return -ENODEV; |
| } |
| } |
| -- |
| 1.8.5.rc3 |
| |