| From 2d69d2e9a74894a32deeeb57a897b65dc622abe4 Mon Sep 17 00:00:00 2001 |
| From: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Date: Thu, 19 Sep 2013 12:18:32 +0200 |
| Subject: drm/i915: use pointer = k[cmz...]alloc(sizeof(*pointer), ...) pattern |
| |
| Done while reviewing all our allocations for fubar. Also a few errant |
| cases of lacking () for the sizeof operator - just a bit of OCD. |
| |
| I've left out all the conversions that also should use kcalloc from |
| this patch (it's only 2). |
| |
| Reviewed-by: Jani Nikula <jani.nikula@intel.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| (cherry picked from commit b14c5679dd2c87b5bd14c49c5bdd1962be2ab209) |
| Signed-off-by: Darren Hart <dvhart@linux.intel.com> |
| --- |
| drivers/gpu/drm/i915/i915_debugfs.c | 2 +- |
| drivers/gpu/drm/i915/i915_dma.c | 6 +++--- |
| drivers/gpu/drm/i915/i915_gem.c | 2 +- |
| drivers/gpu/drm/i915/intel_crt.c | 2 +- |
| drivers/gpu/drm/i915/intel_ddi.c | 6 +++--- |
| drivers/gpu/drm/i915/intel_display.c | 2 +- |
| drivers/gpu/drm/i915/intel_dp.c | 4 ++-- |
| drivers/gpu/drm/i915/intel_dvo.c | 4 ++-- |
| drivers/gpu/drm/i915/intel_fb.c | 2 +- |
| drivers/gpu/drm/i915/intel_hdmi.c | 4 ++-- |
| drivers/gpu/drm/i915/intel_lvds.c | 4 ++-- |
| drivers/gpu/drm/i915/intel_overlay.c | 4 ++-- |
| drivers/gpu/drm/i915/intel_pm.c | 2 +- |
| drivers/gpu/drm/i915/intel_sdvo.c | 10 +++++----- |
| drivers/gpu/drm/i915/intel_sprite.c | 2 +- |
| drivers/gpu/drm/i915/intel_tv.c | 4 ++-- |
| 16 files changed, 30 insertions(+), 30 deletions(-) |
| |
| --- a/drivers/gpu/drm/i915/i915_debugfs.c |
| +++ b/drivers/gpu/drm/i915/i915_debugfs.c |
| @@ -2156,7 +2156,7 @@ drm_add_fake_info_node(struct drm_minor |
| { |
| struct drm_info_node *node; |
| |
| - node = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL); |
| + node = kmalloc(sizeof(*node), GFP_KERNEL); |
| if (node == NULL) { |
| debugfs_remove(ent); |
| return -ENOMEM; |
| --- a/drivers/gpu/drm/i915/i915_dma.c |
| +++ b/drivers/gpu/drm/i915/i915_dma.c |
| @@ -649,7 +649,7 @@ static int i915_batchbuffer(struct drm_d |
| |
| if (batch->num_cliprects) { |
| cliprects = kcalloc(batch->num_cliprects, |
| - sizeof(struct drm_clip_rect), |
| + sizeof(*cliprects), |
| GFP_KERNEL); |
| if (cliprects == NULL) |
| return -ENOMEM; |
| @@ -711,7 +711,7 @@ static int i915_cmdbuffer(struct drm_dev |
| |
| if (cmdbuf->num_cliprects) { |
| cliprects = kcalloc(cmdbuf->num_cliprects, |
| - sizeof(struct drm_clip_rect), GFP_KERNEL); |
| + sizeof(*cliprects), GFP_KERNEL); |
| if (cliprects == NULL) { |
| ret = -ENOMEM; |
| goto fail_batch_free; |
| @@ -1488,7 +1488,7 @@ int i915_driver_load(struct drm_device * |
| dev->types[8] = _DRM_STAT_SECONDARY; |
| dev->types[9] = _DRM_STAT_DMA; |
| |
| - dev_priv = kzalloc(sizeof(drm_i915_private_t), GFP_KERNEL); |
| + dev_priv = kzalloc(sizeof(*dev_priv), GFP_KERNEL); |
| if (dev_priv == NULL) |
| return -ENOMEM; |
| |
| --- a/drivers/gpu/drm/i915/i915_gem.c |
| +++ b/drivers/gpu/drm/i915/i915_gem.c |
| @@ -4630,7 +4630,7 @@ static int i915_gem_init_phys_object(str |
| if (dev_priv->mm.phys_objs[id - 1] || !size) |
| return 0; |
| |
| - phys_obj = kzalloc(sizeof(struct drm_i915_gem_phys_object), GFP_KERNEL); |
| + phys_obj = kzalloc(sizeof(*phys_obj), GFP_KERNEL); |
| if (!phys_obj) |
| return -ENOMEM; |
| |
| --- a/drivers/gpu/drm/i915/intel_crt.c |
| +++ b/drivers/gpu/drm/i915/intel_crt.c |
| @@ -773,7 +773,7 @@ void intel_crt_init(struct drm_device *d |
| if (!crt) |
| return; |
| |
| - intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL); |
| if (!intel_connector) { |
| kfree(crt); |
| return; |
| --- a/drivers/gpu/drm/i915/intel_ddi.c |
| +++ b/drivers/gpu/drm/i915/intel_ddi.c |
| @@ -1343,11 +1343,11 @@ void intel_ddi_init(struct drm_device *d |
| struct intel_connector *hdmi_connector = NULL; |
| struct intel_connector *dp_connector = NULL; |
| |
| - intel_dig_port = kzalloc(sizeof(struct intel_digital_port), GFP_KERNEL); |
| + intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL); |
| if (!intel_dig_port) |
| return; |
| |
| - dp_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + dp_connector = kzalloc(sizeof(*dp_connector), GFP_KERNEL); |
| if (!dp_connector) { |
| kfree(intel_dig_port); |
| return; |
| @@ -1387,7 +1387,7 @@ void intel_ddi_init(struct drm_device *d |
| } |
| |
| if (intel_encoder->type != INTEL_OUTPUT_EDP) { |
| - hdmi_connector = kzalloc(sizeof(struct intel_connector), |
| + hdmi_connector = kzalloc(sizeof(*hdmi_connector), |
| GFP_KERNEL); |
| if (!hdmi_connector) { |
| return; |
| --- a/drivers/gpu/drm/i915/intel_display.c |
| +++ b/drivers/gpu/drm/i915/intel_display.c |
| @@ -8097,7 +8097,7 @@ static int intel_crtc_page_flip(struct d |
| fb->pitches[0] != crtc->fb->pitches[0])) |
| return -EINVAL; |
| |
| - work = kzalloc(sizeof *work, GFP_KERNEL); |
| + work = kzalloc(sizeof(*work), GFP_KERNEL); |
| if (work == NULL) |
| return -ENOMEM; |
| |
| --- a/drivers/gpu/drm/i915/intel_dp.c |
| +++ b/drivers/gpu/drm/i915/intel_dp.c |
| @@ -3649,11 +3649,11 @@ intel_dp_init(struct drm_device *dev, in |
| struct drm_encoder *encoder; |
| struct intel_connector *intel_connector; |
| |
| - intel_dig_port = kzalloc(sizeof(struct intel_digital_port), GFP_KERNEL); |
| + intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL); |
| if (!intel_dig_port) |
| return; |
| |
| - intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL); |
| if (!intel_connector) { |
| kfree(intel_dig_port); |
| return; |
| --- a/drivers/gpu/drm/i915/intel_dvo.c |
| +++ b/drivers/gpu/drm/i915/intel_dvo.c |
| @@ -448,11 +448,11 @@ void intel_dvo_init(struct drm_device *d |
| int i; |
| int encoder_type = DRM_MODE_ENCODER_NONE; |
| |
| - intel_dvo = kzalloc(sizeof(struct intel_dvo), GFP_KERNEL); |
| + intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL); |
| if (!intel_dvo) |
| return; |
| |
| - intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL); |
| if (!intel_connector) { |
| kfree(intel_dvo); |
| return; |
| --- a/drivers/gpu/drm/i915/intel_fb.c |
| +++ b/drivers/gpu/drm/i915/intel_fb.c |
| @@ -216,7 +216,7 @@ int intel_fbdev_init(struct drm_device * |
| struct drm_i915_private *dev_priv = dev->dev_private; |
| int ret; |
| |
| - ifbdev = kzalloc(sizeof(struct intel_fbdev), GFP_KERNEL); |
| + ifbdev = kzalloc(sizeof(*ifbdev), GFP_KERNEL); |
| if (!ifbdev) |
| return -ENOMEM; |
| |
| --- a/drivers/gpu/drm/i915/intel_hdmi.c |
| +++ b/drivers/gpu/drm/i915/intel_hdmi.c |
| @@ -1292,11 +1292,11 @@ void intel_hdmi_init(struct drm_device * |
| struct intel_encoder *intel_encoder; |
| struct intel_connector *intel_connector; |
| |
| - intel_dig_port = kzalloc(sizeof(struct intel_digital_port), GFP_KERNEL); |
| + intel_dig_port = kzalloc(sizeof(*intel_dig_port), GFP_KERNEL); |
| if (!intel_dig_port) |
| return; |
| |
| - intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL); |
| if (!intel_connector) { |
| kfree(intel_dig_port); |
| return; |
| --- a/drivers/gpu/drm/i915/intel_lvds.c |
| +++ b/drivers/gpu/drm/i915/intel_lvds.c |
| @@ -991,11 +991,11 @@ void intel_lvds_init(struct drm_device * |
| } |
| } |
| |
| - lvds_encoder = kzalloc(sizeof(struct intel_lvds_encoder), GFP_KERNEL); |
| + lvds_encoder = kzalloc(sizeof(*lvds_encoder), GFP_KERNEL); |
| if (!lvds_encoder) |
| return; |
| |
| - lvds_connector = kzalloc(sizeof(struct intel_lvds_connector), GFP_KERNEL); |
| + lvds_connector = kzalloc(sizeof(*lvds_connector), GFP_KERNEL); |
| if (!lvds_connector) { |
| kfree(lvds_encoder); |
| return; |
| --- a/drivers/gpu/drm/i915/intel_overlay.c |
| +++ b/drivers/gpu/drm/i915/intel_overlay.c |
| @@ -1053,7 +1053,7 @@ int intel_overlay_put_image(struct drm_d |
| return ret; |
| } |
| |
| - params = kmalloc(sizeof(struct put_image_params), GFP_KERNEL); |
| + params = kmalloc(sizeof(*params), GFP_KERNEL); |
| if (!params) |
| return -ENOMEM; |
| |
| @@ -1320,7 +1320,7 @@ void intel_setup_overlay(struct drm_devi |
| if (!HAS_OVERLAY(dev)) |
| return; |
| |
| - overlay = kzalloc(sizeof(struct intel_overlay), GFP_KERNEL); |
| + overlay = kzalloc(sizeof(*overlay), GFP_KERNEL); |
| if (!overlay) |
| return; |
| |
| --- a/drivers/gpu/drm/i915/intel_pm.c |
| +++ b/drivers/gpu/drm/i915/intel_pm.c |
| @@ -370,7 +370,7 @@ static void intel_enable_fbc(struct drm_ |
| |
| intel_cancel_fbc_work(dev_priv); |
| |
| - work = kzalloc(sizeof *work, GFP_KERNEL); |
| + work = kzalloc(sizeof(*work), GFP_KERNEL); |
| if (work == NULL) { |
| DRM_ERROR("Failed to allocate FBC work structure\n"); |
| dev_priv->display.enable_fbc(crtc, interval); |
| --- a/drivers/gpu/drm/i915/intel_sdvo.c |
| +++ b/drivers/gpu/drm/i915/intel_sdvo.c |
| @@ -2397,7 +2397,7 @@ intel_sdvo_dvi_init(struct intel_sdvo *i |
| struct intel_connector *intel_connector; |
| struct intel_sdvo_connector *intel_sdvo_connector; |
| |
| - intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL); |
| + intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); |
| if (!intel_sdvo_connector) |
| return false; |
| |
| @@ -2445,7 +2445,7 @@ intel_sdvo_tv_init(struct intel_sdvo *in |
| struct intel_connector *intel_connector; |
| struct intel_sdvo_connector *intel_sdvo_connector; |
| |
| - intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL); |
| + intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); |
| if (!intel_sdvo_connector) |
| return false; |
| |
| @@ -2482,7 +2482,7 @@ intel_sdvo_analog_init(struct intel_sdvo |
| struct intel_connector *intel_connector; |
| struct intel_sdvo_connector *intel_sdvo_connector; |
| |
| - intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL); |
| + intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); |
| if (!intel_sdvo_connector) |
| return false; |
| |
| @@ -2513,7 +2513,7 @@ intel_sdvo_lvds_init(struct intel_sdvo * |
| struct intel_connector *intel_connector; |
| struct intel_sdvo_connector *intel_sdvo_connector; |
| |
| - intel_sdvo_connector = kzalloc(sizeof(struct intel_sdvo_connector), GFP_KERNEL); |
| + intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); |
| if (!intel_sdvo_connector) |
| return false; |
| |
| @@ -2879,7 +2879,7 @@ bool intel_sdvo_init(struct drm_device * |
| struct intel_encoder *intel_encoder; |
| struct intel_sdvo *intel_sdvo; |
| int i; |
| - intel_sdvo = kzalloc(sizeof(struct intel_sdvo), GFP_KERNEL); |
| + intel_sdvo = kzalloc(sizeof(*intel_sdvo), GFP_KERNEL); |
| if (!intel_sdvo) |
| return false; |
| |
| --- a/drivers/gpu/drm/i915/intel_sprite.c |
| +++ b/drivers/gpu/drm/i915/intel_sprite.c |
| @@ -1034,7 +1034,7 @@ intel_plane_init(struct drm_device *dev, |
| if (INTEL_INFO(dev)->gen < 5) |
| return -ENODEV; |
| |
| - intel_plane = kzalloc(sizeof(struct intel_plane), GFP_KERNEL); |
| + intel_plane = kzalloc(sizeof(*intel_plane), GFP_KERNEL); |
| if (!intel_plane) |
| return -ENOMEM; |
| |
| --- a/drivers/gpu/drm/i915/intel_tv.c |
| +++ b/drivers/gpu/drm/i915/intel_tv.c |
| @@ -1594,12 +1594,12 @@ intel_tv_init(struct drm_device *dev) |
| (tv_dac_off & TVDAC_STATE_CHG_EN) != 0) |
| return; |
| |
| - intel_tv = kzalloc(sizeof(struct intel_tv), GFP_KERNEL); |
| + intel_tv = kzalloc(sizeof(*intel_tv), GFP_KERNEL); |
| if (!intel_tv) { |
| return; |
| } |
| |
| - intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL); |
| + intel_connector = kzalloc(sizeof(*intel_connector), GFP_KERNEL); |
| if (!intel_connector) { |
| kfree(intel_tv); |
| return; |