| From e9adc96a1b1b04e5e7996707d14306313f898f22 Mon Sep 17 00:00:00 2001 |
| From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Date: Thu, 4 Jul 2013 20:05:50 +0200 |
| Subject: drm/rcar-du: Don't ignore rcar_du_crtc_create() return value |
| |
| Handle error cases correctly. |
| |
| Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Signed-off-by: Dave Airlie <airlied@redhat.com> |
| (cherry picked from commit 3463ff67bc8d049098559adb850299c26b52350d) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +++++-- |
| 1 file changed, 5 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c |
| index 9c63f39658de..06cacf6532c0 100644 |
| --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c |
| +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c |
| @@ -191,8 +191,11 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu) |
| if (ret < 0) |
| return ret; |
| |
| - for (i = 0; i < ARRAY_SIZE(rcdu->crtcs); ++i) |
| - rcar_du_crtc_create(rcdu, i); |
| + for (i = 0; i < ARRAY_SIZE(rcdu->crtcs); ++i) { |
| + ret = rcar_du_crtc_create(rcdu, i); |
| + if (ret < 0) |
| + return ret; |
| + } |
| |
| rcdu->used_crtcs = 0; |
| rcdu->num_crtcs = i; |
| -- |
| 1.8.5.rc3 |
| |