| From 0bee888c66def356a15d70b727b0e9fe4c4895d3 Mon Sep 17 00:00:00 2001 |
| From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
| Date: Fri, 20 Dec 2013 01:41:12 +0300 |
| Subject: sh_eth: do not reset PHY needlessly |
| |
| There's no need anymore to call phy_init_hw() to reset/resume the PHY from the |
| driver, as the call chain in phylib already has reached it, and so reset/resumed |
| the PHY (even resuming it twice). This duplicate reset is not only needless, it |
| e.g. clears the PHY's interrupt enables just setup by phylib and so prevents the |
| expected IRQs from the PHY. |
| |
| Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| (cherry picked from commit 4174ecd78f6591a3d1ec04738ef7bc900a11f5ce) |
| (Queued by David Miller for v3.14 but not yet in Linus's tree) |
| Signed-off-by: Simon Horman <horms+renesas@verge.net.au> |
| --- |
| drivers/net/ethernet/renesas/sh_eth.c | 5 ----- |
| 1 file changed, 5 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c |
| index 2b8ef6ec0025..6551b72776ce 100644 |
| --- a/drivers/net/ethernet/renesas/sh_eth.c |
| +++ b/drivers/net/ethernet/renesas/sh_eth.c |
| @@ -1703,11 +1703,6 @@ static int sh_eth_phy_start(struct net_device *ndev) |
| if (ret) |
| return ret; |
| |
| - /* reset phy - this also wakes it from PDOWN */ |
| - ret = phy_init_hw(mdp->phydev); |
| - if (ret) |
| - return ret; |
| - |
| phy_start(mdp->phydev); |
| |
| return 0; |
| -- |
| 1.8.5.rc3 |
| |
