| From 945e4a66107c401ee6beb320dee0fe1244bb666e Mon Sep 17 00:00:00 2001 |
| From: Eric Dumazet <eric.dumazet@gmail.com> |
| Date: Fri, 15 Oct 2010 14:34:12 -0700 |
| Subject: [PATCH] sysctl: min/max bounds are optional |
| |
| commit a9febbb4bd1302b6f01aa1203b0a804e4e5c9e25 upstream |
| |
| sysctl check complains with a WARN() when proc_doulongvec_minmax() or |
| proc_doulongvec_ms_jiffies_minmax() are used by a vector of longs (with |
| more than one element), with no min or max value specified. |
| |
| This is unexpected, given we had a bug on this min/max handling :) |
| |
| Reported-by: Jiri Slaby <jirislaby@gmail.com> |
| Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> |
| Cc: "Eric W. Biederman" <ebiederm@xmission.com> |
| Cc: David Miller <davem@davemloft.net> |
| Acked-by: WANG Cong <xiyou.wangcong@gmail.com> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/kernel/sysctl_check.c b/kernel/sysctl_check.c |
| index 04cdcf7..10b90d8 100644 |
| --- a/kernel/sysctl_check.c |
| +++ b/kernel/sysctl_check.c |
| @@ -143,15 +143,6 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table) |
| if (!table->maxlen) |
| set_fail(&fail, table, "No maxlen"); |
| } |
| - if ((table->proc_handler == proc_doulongvec_minmax) || |
| - (table->proc_handler == proc_doulongvec_ms_jiffies_minmax)) { |
| - if (table->maxlen > sizeof (unsigned long)) { |
| - if (!table->extra1) |
| - set_fail(&fail, table, "No min"); |
| - if (!table->extra2) |
| - set_fail(&fail, table, "No max"); |
| - } |
| - } |
| #ifdef CONFIG_PROC_SYSCTL |
| if (table->procname && !table->proc_handler) |
| set_fail(&fail, table, "No proc_handler"); |
| -- |
| 1.7.4.4 |
| |
