| From 50761b33d31154b39153204ecdd60dd481cda1e3 Mon Sep 17 00:00:00 2001 |
| From: Greg Kroah-Hartman <gregkh@suse.de> |
| Date: Mon, 15 Nov 2010 11:11:45 -0800 |
| Subject: [PATCH] USB: atm: ueagle-atm: fix up some permissions on the sysfs |
| files |
| |
| commit e502ac5e1eca99d7dc3f12b2a6780ccbca674858 upstream. |
| |
| Some of the sysfs files had the incorrect permissions. Some didn't make |
| sense at all (writable for a file that you could not write to?) |
| |
| Reported-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Cc: Matthieu Castet <castet.matthieu@free.fr> |
| Cc: Stanislaw Gruszka <stf_xl@wp.pl> |
| Cc: Damien Bergamini <damien.bergamini@free.fr> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c |
| index 25f01b5..4c87b1b 100644 |
| --- a/drivers/usb/atm/ueagle-atm.c |
| +++ b/drivers/usb/atm/ueagle-atm.c |
| @@ -2261,7 +2261,7 @@ out: |
| return ret; |
| } |
| |
| -static DEVICE_ATTR(stat_status, S_IWUGO | S_IRUGO, read_status, reboot); |
| +static DEVICE_ATTR(stat_status, S_IWUSR | S_IRUGO, read_status, reboot); |
| |
| static ssize_t read_human_status(struct device *dev, struct device_attribute *attr, |
| char *buf) |
| @@ -2324,7 +2324,7 @@ out: |
| return ret; |
| } |
| |
| -static DEVICE_ATTR(stat_human_status, S_IWUGO | S_IRUGO, read_human_status, NULL); |
| +static DEVICE_ATTR(stat_human_status, S_IRUGO, read_human_status, NULL); |
| |
| static ssize_t read_delin(struct device *dev, struct device_attribute *attr, |
| char *buf) |
| @@ -2356,7 +2356,7 @@ out: |
| return ret; |
| } |
| |
| -static DEVICE_ATTR(stat_delin, S_IWUGO | S_IRUGO, read_delin, NULL); |
| +static DEVICE_ATTR(stat_delin, S_IRUGO, read_delin, NULL); |
| |
| #define UEA_ATTR(name, reset) \ |
| \ |
| -- |
| 1.7.4.4 |
| |
