| From 42161e9e9105062e8a898caf080e5b077a0b7a62 Mon Sep 17 00:00:00 2001 |
| From: David S. Miller <davem@davemloft.net> |
| Date: Wed, 9 Feb 2011 21:48:36 -0800 |
| Subject: [PATCH] x25: Do not reference freed memory. |
| |
| commit 96642d42f076101ba98866363d908cab706d156c upstream. |
| |
| In x25_link_free(), we destroy 'nb' before dereferencing |
| 'nb->dev'. Don't do this, because 'nb' might be freed |
| by then. |
| |
| Reported-by: Randy Dunlap <randy.dunlap@oracle.com> |
| Tested-by: Randy Dunlap <randy.dunlap@oracle.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/x25/x25_link.c b/net/x25/x25_link.c |
| index b25c646..88048b6 100644 |
| --- a/net/x25/x25_link.c |
| +++ b/net/x25/x25_link.c |
| @@ -392,9 +392,12 @@ void __exit x25_link_free(void) |
| write_lock_bh(&x25_neigh_list_lock); |
| |
| list_for_each_safe(entry, tmp, &x25_neigh_list) { |
| + struct net_device *dev; |
| + |
| nb = list_entry(entry, struct x25_neigh, node); |
| + dev = nb->dev; |
| __x25_remove_neigh(nb); |
| - dev_put(nb->dev); |
| + dev_put(dev); |
| } |
| write_unlock_bh(&x25_neigh_list_lock); |
| } |
| -- |
| 1.7.4.4 |
| |
