| From 9c8bb163ae784be4f79ae504e78c862806087c54 Mon Sep 17 00:00:00 2001 |
| From: Hangbin Liu <liuhangbin@gmail.com> |
| Date: Wed, 8 Feb 2017 21:16:45 +0800 |
| Subject: [PATCH] igmp, mld: Fix memory leak in igmpv3/mld_del_delrec() |
| |
| commit 9c8bb163ae784be4f79ae504e78c862806087c54 upstream. |
| |
| In function igmpv3/mld_add_delrec() we allocate pmc and put it in |
| idev->mc_tomb, so we should free it when we don't need it in del_delrec(). |
| But I removed kfree(pmc) incorrectly in latest two patches. Now fix it. |
| |
| Fixes: 24803f38a5c0 ("igmp: do not remove igmp souce list info when ...") |
| Fixes: 1666d49e1d41 ("mld: do not remove mld souce list info when ...") |
| Reported-by: Daniel Borkmann <daniel@iogearbox.net> |
| Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| |
| diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c |
| index 5b15459955f8..44fd86de2823 100644 |
| --- a/net/ipv4/igmp.c |
| +++ b/net/ipv4/igmp.c |
| @@ -1172,6 +1172,7 @@ static void igmpv3_del_delrec(struct in_device *in_dev, struct ip_mc_list *im) |
| psf->sf_crcount = im->crcount; |
| } |
| in_dev_put(pmc->interface); |
| + kfree(pmc); |
| } |
| spin_unlock_bh(&im->lock); |
| } |
| diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c |
| index 7139fffd61b6..1bdc703cb966 100644 |
| --- a/net/ipv6/mcast.c |
| +++ b/net/ipv6/mcast.c |
| @@ -779,6 +779,7 @@ static void mld_del_delrec(struct inet6_dev *idev, struct ifmcaddr6 *im) |
| psf->sf_crcount = im->mca_crcount; |
| } |
| in6_dev_put(pmc->idev); |
| + kfree(pmc); |
| } |
| spin_unlock_bh(&im->mca_lock); |
| } |
| -- |
| 2.12.0 |
| |
