| From 864e9f46045ec43e1e8f36f5dca34cad2da6a475 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Mon, 6 Mar 2017 17:36:38 +0100 |
| Subject: [PATCH] USB: serial: omninet: fix reference leaks at open |
| |
| commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream. |
| |
| This driver needlessly took another reference to the tty on open, a |
| reference which was then never released on close. This lead to not just |
| a leak of the tty, but also a driver reference leak that prevented the |
| driver from being unloaded after a port had once been opened. |
| |
| Fixes: 4a90f09b20f4 ("tty: usb-serial krefs") |
| Cc: stable <stable@vger.kernel.org> # 2.6.28 |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c |
| index a180b17d2432..76564b3bebb9 100644 |
| --- a/drivers/usb/serial/omninet.c |
| +++ b/drivers/usb/serial/omninet.c |
| @@ -142,12 +142,6 @@ static int omninet_port_remove(struct usb_serial_port *port) |
| |
| static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port) |
| { |
| - struct usb_serial *serial = port->serial; |
| - struct usb_serial_port *wport; |
| - |
| - wport = serial->port[1]; |
| - tty_port_tty_set(&wport->port, tty); |
| - |
| return usb_serial_generic_open(tty, port); |
| } |
| |
| -- |
| 2.12.0 |
| |
