| From 5cc4a1a9f5c179795c8a1f2b0f4361829d6a070e Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 16 Mar 2017 11:37:01 -0700 |
| Subject: [PATCH] Input: yealink - validate number of endpoints before using |
| them |
| |
| commit 5cc4a1a9f5c179795c8a1f2b0f4361829d6a070e upstream. |
| |
| Make sure to check the number of endpoints to avoid dereferencing a |
| NULL-pointer should a malicious device lack endpoints. |
| |
| Fixes: aca951a22a1d ("[PATCH] input-driver-yealink-P1K-usb-phone") |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Cc: stable@vger.kernel.org # 2.6.14 |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| |
| diff --git a/drivers/input/misc/yealink.c b/drivers/input/misc/yealink.c |
| index 79c964c075f1..6e7ff9561d92 100644 |
| --- a/drivers/input/misc/yealink.c |
| +++ b/drivers/input/misc/yealink.c |
| @@ -875,6 +875,10 @@ static int usb_probe(struct usb_interface *intf, const struct usb_device_id *id) |
| int ret, pipe, i; |
| |
| interface = intf->cur_altsetting; |
| + |
| + if (interface->desc.bNumEndpoints < 1) |
| + return -ENODEV; |
| + |
| endpoint = &interface->endpoint[0].desc; |
| if (!usb_endpoint_is_int_in(endpoint)) |
| return -ENODEV; |
| -- |
| 2.12.0 |
| |