| From cc25ee7b6d64c8b0ee94ba50775b6505fec17388 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Tue, 3 Jan 2017 16:39:50 +0100 |
| Subject: [PATCH] USB: serial: mos7720: fix NULL-deref at open |
| |
| commit b05aebc25fdc5aeeac3ee29f0dc9f58dd07c13cc upstream. |
| |
| Fix NULL-pointer dereference at port open if a device lacks the expected |
| bulk in and out endpoints. |
| |
| Unable to handle kernel NULL pointer dereference at virtual address 00000030 |
| ... |
| [<bf071c20>] (mos7720_open [mos7720]) from [<bf0490e0>] (serial_port_activate+0x68/0x98 [usbserial]) |
| [<bf0490e0>] (serial_port_activate [usbserial]) from [<c0470ca4>] (tty_port_open+0x9c/0xe8) |
| [<c0470ca4>] (tty_port_open) from [<bf049d98>] (serial_open+0x48/0x6c [usbserial]) |
| [<bf049d98>] (serial_open [usbserial]) from [<c0469178>] (tty_open+0xcc/0x5cc) |
| |
| Fixes: 0f64478cbc7a ("USB: add USB serial mos7720 driver") |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c |
| index de9992b492b0..8d085eb95ff9 100644 |
| --- a/drivers/usb/serial/mos7720.c |
| +++ b/drivers/usb/serial/mos7720.c |
| @@ -1920,6 +1920,11 @@ static int mos7720_startup(struct usb_serial *serial) |
| u16 product; |
| int ret_val; |
| |
| + if (serial->num_bulk_in < 2 || serial->num_bulk_out < 2) { |
| + dev_err(&serial->interface->dev, "missing bulk endpoints\n"); |
| + return -ENODEV; |
| + } |
| + |
| product = le16_to_cpu(serial->dev->descriptor.idProduct); |
| dev = serial->dev; |
| |
| -- |
| 2.10.1 |
| |
