blob: 84b4608e6907fd8006b03d6cf27844a6ac255f1d [file] [log] [blame]
From 105a047986d37a8ab024ee80b38215ccb2d9c426 Mon Sep 17 00:00:00 2001
From: Colin Ian King <>
Date: Thu, 6 Aug 2020 15:35:34 -0700
Subject: [PATCH] Input: sentelic - fix error return when fsp_reg_write fails
commit ea38f06e0291986eb93beb6d61fd413607a30ca4 upstream.
Currently when the call to fsp_reg_write fails -EIO is not being returned
because the count is being returned instead of the return value in retval.
Fix this by returning the value in retval instead of count.
Addresses-Coverity: ("Unused value")
Fixes: fc69f4a6af49 ("Input: add new driver for Sentelic Finger Sensing Pad")
Signed-off-by: Colin Ian King <>
Signed-off-by: Dmitry Torokhov <>
Signed-off-by: Paul Gortmaker <>
diff --git a/drivers/input/mouse/sentelic.c b/drivers/input/mouse/sentelic.c
index e99d9bf1a267..e78c4c7eda34 100644
--- a/drivers/input/mouse/sentelic.c
+++ b/drivers/input/mouse/sentelic.c
@@ -441,7 +441,7 @@ static ssize_t fsp_attr_set_setreg(struct psmouse *psmouse, void *data,
fsp_reg_write_enable(psmouse, false);
- return count;
+ return retval;
PSMOUSE_DEFINE_WO_ATTR(setreg, S_IWUSR, NULL, fsp_attr_set_setreg);