| From 36b10ca4f94224b53897ca8311685278991aa0ea Mon Sep 17 00:00:00 2001 |
| From: Jing Xiangfeng <jingxiangfeng@huawei.com> |
| Date: Tue, 14 Jul 2020 16:09:18 +0800 |
| Subject: [PATCH] ASoC: Intel: bytcht_es8316: Add missed put_device() |
| |
| commit b3df80ab6d147d4738be242e1c91e5fdbb6b03ef upstream. |
| |
| snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error |
| path. Add the missed function call to fix it. |
| |
| Fixes: ba49cf6f8e4a ("ASoC: Intel: bytcht_es8316: Add quirk for inverted jack detect") |
| Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com> |
| Reviewed-by: Hans de Goede <hdegoede@redhat.com> |
| Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> |
| Link: https://lore.kernel.org/r/20200714080918.148196-1-jingxiangfeng@huawei.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c |
| index 4602c4f41c16..1d2fe84bd3d7 100644 |
| --- a/sound/soc/intel/boards/bytcht_es8316.c |
| +++ b/sound/soc/intel/boards/bytcht_es8316.c |
| @@ -547,8 +547,10 @@ static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev) |
| |
| if (cnt) { |
| ret = device_add_properties(codec_dev, props); |
| - if (ret) |
| + if (ret) { |
| + put_device(codec_dev); |
| return ret; |
| + } |
| } |
| |
| devm_acpi_dev_add_driver_gpios(codec_dev, byt_cht_es8316_gpios); |
| -- |
| 2.27.0 |
| |
