| From cce521d5ebbabb01d304843465dffc2ca580f060 Mon Sep 17 00:00:00 2001 |
| From: Xu Wang <vulab@iscas.ac.cn> |
| Date: Thu, 26 Mar 2020 18:14:29 +0800 |
| Subject: [PATCH] qlcnic: Fix bad kzalloc null test |
| |
| commit bcaeb886ade124331a6f3a5cef34a3f1484c0a03 upstream. |
| |
| In qlcnic_83xx_get_reset_instruction_template, the variable |
| of null test is bad, so correct it. |
| |
| Signed-off-by: Xu Wang <vulab@iscas.ac.cn> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c |
| index 07f9067affc6..cda5b0a9e948 100644 |
| --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c |
| +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c |
| @@ -1720,7 +1720,7 @@ static int qlcnic_83xx_get_reset_instruction_template(struct qlcnic_adapter *p_d |
| |
| ahw->reset.seq_error = 0; |
| ahw->reset.buff = kzalloc(QLC_83XX_RESTART_TEMPLATE_SIZE, GFP_KERNEL); |
| - if (p_dev->ahw->reset.buff == NULL) |
| + if (ahw->reset.buff == NULL) |
| return -ENOMEM; |
| |
| p_buff = p_dev->ahw->reset.buff; |
| -- |
| 2.7.4 |
| |
