| From 45b6f0c004130efc07890b645a8473fbe778bfa7 Mon Sep 17 00:00:00 2001 |
| From: Wei Yongjun <weiyongjun1@huawei.com> |
| Date: Wed, 4 Sep 2019 14:18:09 +0000 |
| Subject: [PATCH] crypto: cavium/zip - Add missing single_release() |
| |
| commit c552ffb5c93d9d65aaf34f5f001c4e7e8484ced1 upstream. |
| |
| When using single_open() for opening, single_release() should be |
| used instead of seq_release(), otherwise there is a memory leak. |
| |
| Fixes: 09ae5d37e093 ("crypto: zip - Add Compression/Decompression statistics") |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/crypto/cavium/zip/zip_main.c b/drivers/crypto/cavium/zip/zip_main.c |
| index a8447a3cf366..194624b4855b 100644 |
| --- a/drivers/crypto/cavium/zip/zip_main.c |
| +++ b/drivers/crypto/cavium/zip/zip_main.c |
| @@ -593,6 +593,7 @@ static const struct file_operations zip_stats_fops = { |
| .owner = THIS_MODULE, |
| .open = zip_stats_open, |
| .read = seq_read, |
| + .release = single_release, |
| }; |
| |
| static int zip_clear_open(struct inode *inode, struct file *file) |
| @@ -604,6 +605,7 @@ static const struct file_operations zip_clear_fops = { |
| .owner = THIS_MODULE, |
| .open = zip_clear_open, |
| .read = seq_read, |
| + .release = single_release, |
| }; |
| |
| static int zip_regs_open(struct inode *inode, struct file *file) |
| @@ -615,6 +617,7 @@ static const struct file_operations zip_regs_fops = { |
| .owner = THIS_MODULE, |
| .open = zip_regs_open, |
| .read = seq_read, |
| + .release = single_release, |
| }; |
| |
| /* Root directory for thunderx_zip debugfs entry */ |
| -- |
| 2.7.4 |
| |
