| From af27e0abb87a6dcb1a3d1c5f05b57bba29edf6c2 Mon Sep 17 00:00:00 2001 |
| From: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Date: Mon, 21 Oct 2019 15:06:48 -0500 |
| Subject: [PATCH] ipmi: Fix memory leak in __ipmi_bmc_register |
| |
| commit 4aa7afb0ee20a97fbf0c5bab3df028d5fb85fdab upstream. |
| |
| In the impelementation of __ipmi_bmc_register() the allocated memory for |
| bmc should be released in case ida_simple_get() fails. |
| |
| Fixes: 68e7e50f195f ("ipmi: Don't use BMC product/dev ids in the BMC name") |
| Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> |
| Message-Id: <20191021200649.1511-1-navid.emamdoost@gmail.com> |
| Signed-off-by: Corey Minyard <cminyard@mvista.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c |
| index 6ce64007b3c0..850ccd4baaf9 100644 |
| --- a/drivers/char/ipmi/ipmi_msghandler.c |
| +++ b/drivers/char/ipmi/ipmi_msghandler.c |
| @@ -3028,8 +3028,11 @@ static int __ipmi_bmc_register(struct ipmi_smi *intf, |
| bmc->pdev.name = "ipmi_bmc"; |
| |
| rv = ida_simple_get(&ipmi_bmc_ida, 0, 0, GFP_KERNEL); |
| - if (rv < 0) |
| + if (rv < 0) { |
| + kfree(bmc); |
| goto out; |
| + } |
| + |
| bmc->pdev.dev.driver = &ipmidriver.driver; |
| bmc->pdev.id = rv; |
| bmc->pdev.dev.release = release_bmc_device; |
| -- |
| 2.7.4 |
| |
