| From 1da6d7af58b3e3f44f27d5cbec0ca14332a40468 Mon Sep 17 00:00:00 2001 |
| From: Xiaolong Huang <butterflyhuangxx@gmail.com> |
| Date: Sat, 7 Dec 2019 22:40:24 +0800 |
| Subject: [PATCH] can: kvaser_usb: kvaser_usb_leaf: Fix some info-leaks to USB |
| devices |
| |
| commit da2311a6385c3b499da2ed5d9be59ce331fa93e9 upstream. |
| |
| Uninitialized Kernel memory can leak to USB devices. |
| |
| Fix this by using kzalloc() instead of kmalloc(). |
| |
| Signed-off-by: Xiaolong Huang <butterflyhuangxx@gmail.com> |
| Fixes: 7259124eac7d ("can: kvaser_usb: Split driver into kvaser_usb_core.c and kvaser_usb_leaf.c") |
| Cc: linux-stable <stable@vger.kernel.org> # >= v4.19 |
| Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c |
| index 07d2f3aa2c02..ae4c37e1bb75 100644 |
| --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c |
| +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c |
| @@ -608,7 +608,7 @@ static int kvaser_usb_leaf_simple_cmd_async(struct kvaser_usb_net_priv *priv, |
| struct kvaser_cmd *cmd; |
| int err; |
| |
| - cmd = kmalloc(sizeof(*cmd), GFP_ATOMIC); |
| + cmd = kzalloc(sizeof(*cmd), GFP_ATOMIC); |
| if (!cmd) |
| return -ENOMEM; |
| |
| @@ -1140,7 +1140,7 @@ static int kvaser_usb_leaf_set_opt_mode(const struct kvaser_usb_net_priv *priv) |
| struct kvaser_cmd *cmd; |
| int rc; |
| |
| - cmd = kmalloc(sizeof(*cmd), GFP_KERNEL); |
| + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); |
| if (!cmd) |
| return -ENOMEM; |
| |
| @@ -1206,7 +1206,7 @@ static int kvaser_usb_leaf_flush_queue(struct kvaser_usb_net_priv *priv) |
| struct kvaser_cmd *cmd; |
| int rc; |
| |
| - cmd = kmalloc(sizeof(*cmd), GFP_KERNEL); |
| + cmd = kzalloc(sizeof(*cmd), GFP_KERNEL); |
| if (!cmd) |
| return -ENOMEM; |
| |
| -- |
| 2.7.4 |
| |