| From f7e02fd905d8f024c8dd99b5f4eebdf3230f7092 Mon Sep 17 00:00:00 2001 |
| From: Chuhong Yuan <hslester96@gmail.com> |
| Date: Thu, 28 Nov 2019 10:00:21 +0800 |
| Subject: [PATCH] net: macb: add missed tasklet_kill |
| |
| commit 61183b056b49e2937ff92a1424291ba36a6f6d05 upstream. |
| |
| This driver forgets to kill tasklet in remove. |
| Add the call to fix it. |
| |
| Fixes: 032dc41ba6e2 ("net: macb: Handle HRESP error") |
| Signed-off-by: Chuhong Yuan <hslester96@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c |
| index 262a28ff81fc..a947050c4443 100644 |
| --- a/drivers/net/ethernet/cadence/macb_main.c |
| +++ b/drivers/net/ethernet/cadence/macb_main.c |
| @@ -4269,6 +4269,7 @@ static int macb_remove(struct platform_device *pdev) |
| mdiobus_free(bp->mii_bus); |
| |
| unregister_netdev(dev); |
| + tasklet_kill(&bp->hresp_err_tasklet); |
| pm_runtime_disable(&pdev->dev); |
| pm_runtime_dont_use_autosuspend(&pdev->dev); |
| if (!pm_runtime_suspended(&pdev->dev)) { |
| -- |
| 2.7.4 |
| |
