| From c7c41b93bd070aa42f9e0609defadce268fe125a Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Thu, 3 Oct 2019 22:52:27 +0100 |
| Subject: [PATCH] drm/amdgpu: fix uninitialized variable pasid_mapping_needed |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| commit 17cf678a33c6196a3df4531fe5aec91384c9eeb5 upstream. |
| |
| The boolean variable pasid_mapping_needed is not initialized and |
| there are code paths that do not assign it any value before it is |
| is read later. Fix this by initializing pasid_mapping_needed to |
| false. |
| |
| Addresses-Coverity: ("Uninitialized scalar variable") |
| Fixes: 6817bf283b2b ("drm/amdgpu: grab the id mgr lock while accessing passid_mapping") |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |
| index 7ff2afec477e..6df8aaa17be9 100644 |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c |
| @@ -1037,7 +1037,7 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, bool need_ |
| id->oa_size != job->oa_size); |
| bool vm_flush_needed = job->vm_needs_flush; |
| struct dma_fence *fence = NULL; |
| - bool pasid_mapping_needed; |
| + bool pasid_mapping_needed = false; |
| unsigned patch_offset = 0; |
| int r; |
| |
| -- |
| 2.7.4 |
| |
