| From 05425784c45b0c52f96592cc43c1aa3fd6145afa Mon Sep 17 00:00:00 2001 |
| From: Takashi Iwai <tiwai@suse.de> |
| Date: Mon, 16 Dec 2019 16:12:24 +0100 |
| Subject: [PATCH] ALSA: hda - Downgrade error message for single-cmd fallback |
| |
| commit 475feec0c41ad71cb7d02f0310e56256606b57c5 upstream. |
| |
| We made the error message for the CORB/RIRB communication clearer by |
| upgrading to dev_WARN() so that user can notice better. But this |
| struck us like a boomerang: now it caught syzbot and reported back as |
| a fatal issue although it's not really any too serious bug that worth |
| for stopping the whole system. |
| |
| OK, OK, let's be softy, downgrade it to the standard dev_err() again. |
| |
| Fixes: dd65f7e19c69 ("ALSA: hda - Show the fatal CORB/RIRB error more clearly") |
| Reported-by: syzbot+b3028ac3933f5c466389@syzkaller.appspotmail.com |
| Link: https://lore.kernel.org/r/20191216151224.30013-1-tiwai@suse.de |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c |
| index 1158bcf55148..a25a68ab9abb 100644 |
| --- a/sound/pci/hda/hda_controller.c |
| +++ b/sound/pci/hda/hda_controller.c |
| @@ -875,7 +875,7 @@ static int azx_rirb_get_response(struct hdac_bus *bus, unsigned int addr, |
| return -EAGAIN; /* give a chance to retry */ |
| } |
| |
| - dev_WARN(chip->card->dev, |
| + dev_err(chip->card->dev, |
| "azx_get_response timeout, switching to single_cmd mode: last cmd=0x%08x\n", |
| bus->last_cmd[addr]); |
| chip->single_cmd = 1; |
| -- |
| 2.7.4 |
| |
