| From fafdb431cbeb434d24853fc81fd7e4739da222c3 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 28 Nov 2019 18:22:02 +0100 |
| Subject: [PATCH] rsi: fix memory leak on failed URB submission |
| |
| commit 47768297481184932844ab01a86752ba31a38861 upstream. |
| |
| Make sure to free the skb on failed receive-URB submission (e.g. on |
| disconnect or currently also due to a missing endpoint). |
| |
| Fixes: a1854fae1414 ("rsi: improve RX packet handling in USB interface") |
| Cc: stable <stable@vger.kernel.org> # 4.17 |
| Cc: Prameela Rani Garnepudi <prameela.j04cs@gmail.com> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/wireless/rsi/rsi_91x_usb.c b/drivers/net/wireless/rsi/rsi_91x_usb.c |
| index e8957329c125..64c56ce94136 100644 |
| --- a/drivers/net/wireless/rsi/rsi_91x_usb.c |
| +++ b/drivers/net/wireless/rsi/rsi_91x_usb.c |
| @@ -338,8 +338,10 @@ static int rsi_rx_urb_submit(struct rsi_hw *adapter, u8 ep_num) |
| rx_cb); |
| |
| status = usb_submit_urb(urb, GFP_KERNEL); |
| - if (status) |
| + if (status) { |
| rsi_dbg(ERR_ZONE, "%s: Failed in urb submission\n", __func__); |
| + dev_kfree_skb(skb); |
| + } |
| |
| return status; |
| } |
| -- |
| 2.7.4 |
| |