| From 5e7ebb5a369856b49f52725a509b6e09cafa591a Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Fri, 11 Oct 2019 17:11:15 +0300 |
| Subject: [PATCH] USB: legousbtower: fix a signedness bug in tower_probe() |
| |
| commit fd47a417e75e2506eb3672ae569b1c87e3774155 upstream. |
| |
| The problem is that sizeof() is unsigned long so negative error codes |
| are type promoted to high positive values and the condition becomes |
| false. |
| |
| Fixes: 1d427be4a39d ("USB: legousbtower: fix slab info leak at probe") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Acked-by: Johan Hovold <johan@kernel.org> |
| Link: https://lore.kernel.org/r/20191011141115.GA4521@mwanda |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c |
| index 9d4c52a7ebe0..9bd240df8f4c 100644 |
| --- a/drivers/usb/misc/legousbtower.c |
| +++ b/drivers/usb/misc/legousbtower.c |
| @@ -881,7 +881,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device |
| get_version_reply, |
| sizeof(*get_version_reply), |
| 1000); |
| - if (result < sizeof(*get_version_reply)) { |
| + if (result != sizeof(*get_version_reply)) { |
| if (result >= 0) |
| result = -EIO; |
| dev_err(idev, "get version request failed: %d\n", result); |
| -- |
| 2.7.4 |
| |
