| From 707389870a93b6b4110d2c3a45d243b3f29662cf Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 3 Oct 2019 09:09:31 +0200 |
| Subject: [PATCH] USB: microtek: fix info-leak at probe |
| |
| commit 177238c3d47d54b2ed8f0da7a4290db492f4a057 upstream. |
| |
| Add missing bulk-in endpoint sanity check to prevent uninitialised stack |
| data from being reported to the system log and used as endpoint |
| addresses. |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Cc: stable <stable@vger.kernel.org> |
| Reported-by: syzbot+5630ca7c3b2be5c9da5e@syzkaller.appspotmail.com |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Acked-by: Oliver Neukum <oneukum@suse.com> |
| Link: https://lore.kernel.org/r/20191003070931.17009-1-johan@kernel.org |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c |
| index 607be1f4fe27..b0a21a04829b 100644 |
| --- a/drivers/usb/image/microtek.c |
| +++ b/drivers/usb/image/microtek.c |
| @@ -720,6 +720,10 @@ static int mts_usb_probe(struct usb_interface *intf, |
| |
| } |
| |
| + if (ep_in_current != &ep_in_set[2]) { |
| + MTS_WARNING("couldn't find two input bulk endpoints. Bailing out.\n"); |
| + return -ENODEV; |
| + } |
| |
| if ( ep_out == -1 ) { |
| MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" ); |
| -- |
| 2.7.4 |
| |
