| From 343cc83d74fe92fe8e7c871e483cd29d0b301264 Mon Sep 17 00:00:00 2001 |
| From: Anders Roxell <anders.roxell@linaro.org> |
| Date: Tue, 30 Jul 2019 17:30:56 +0200 |
| Subject: [PATCH] drm: mali-dp: Mark expected switch fall-through |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| commit 28ba1b1da49a20ba8fb767d6ddd7c521ec79a119 upstream. |
| |
| Now that -Wimplicit-fallthrough is passed to GCC by default, the |
| following warnings shows up: |
| |
| ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_format_get_bpp’: |
| ../drivers/gpu/drm/arm/malidp_hw.c:387:8: warning: this statement may fall |
| through [-Wimplicit-fallthrough=] |
| bpp = 30; |
| ~~~~^~~~ |
| ../drivers/gpu/drm/arm/malidp_hw.c:388:3: note: here |
| case DRM_FORMAT_YUV420_10BIT: |
| ^~~~ |
| ../drivers/gpu/drm/arm/malidp_hw.c: In function ‘malidp_se_irq’: |
| ../drivers/gpu/drm/arm/malidp_hw.c:1311:4: warning: this statement may fall |
| through [-Wimplicit-fallthrough=] |
| drm_writeback_signal_completion(&malidp->mw_connector, 0); |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| ../drivers/gpu/drm/arm/malidp_hw.c:1313:3: note: here |
| case MW_START: |
| ^~~~ |
| |
| Rework to add a 'break;' in a case that didn't have it so that |
| the compiler doesn't warn about fall-through. |
| |
| Cc: stable@vger.kernel.org # v5.2+ |
| Fixes: b8207562abdd ("drm/arm/malidp: Specified the rotation memory requirements for AFBC YUV formats") |
| Acked-by: Liviu Dudau <liviu.dudau@arm.com> |
| Signed-off-by: Anders Roxell <anders.roxell@linaro.org> |
| Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20190730153056.3606-1-anders.roxell@linaro.org |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_hw.c |
| index 5aa7b81ba4c9..a9163d58ddf6 100644 |
| --- a/drivers/gpu/drm/arm/malidp_hw.c |
| +++ b/drivers/gpu/drm/arm/malidp_hw.c |
| @@ -384,6 +384,7 @@ int malidp_format_get_bpp(u32 fmt) |
| switch (fmt) { |
| case DRM_FORMAT_VUY101010: |
| bpp = 30; |
| + break; |
| case DRM_FORMAT_YUV420_10BIT: |
| bpp = 15; |
| break; |
| @@ -1308,7 +1309,7 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) |
| break; |
| case MW_RESTART: |
| drm_writeback_signal_completion(&malidp->mw_connector, 0); |
| - /* fall through to a new start */ |
| + /* fall through - to a new start */ |
| case MW_START: |
| /* writeback started, need to emulate one-shot mode */ |
| hw->disable_memwrite(hwdev); |
| -- |
| 2.7.4 |
| |