| From 50ab6da0d8cd12a8efd86da959fee9106af3e4f7 Mon Sep 17 00:00:00 2001 |
| From: Bruce Chen <bruce.chen@unisoc.com> |
| Date: Mon, 16 Sep 2019 17:56:56 +0800 |
| Subject: [PATCH] gpio: eic: sprd: Fix the incorrect EIC offset when toggling |
| |
| commit e91aafcb51f3c5001ae76c3ee027beb0b8506447 upstream. |
| |
| When toggling the level trigger to emulate the edge trigger, the |
| EIC offset is incorrect without adding the corresponding bank index, |
| thus fix it. |
| |
| Fixes: 7bf0d7f62282 ("gpio: eic: Add edge trigger emulation for EIC") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Bruce Chen <bruce.chen@unisoc.com> |
| Signed-off-by: Baolin Wang <baolin.wang@linaro.org> |
| Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c |
| index 77092268ee95..3b0620bc48a5 100644 |
| --- a/drivers/gpio/gpio-eic-sprd.c |
| +++ b/drivers/gpio/gpio-eic-sprd.c |
| @@ -530,11 +530,12 @@ static void sprd_eic_handle_one_type(struct gpio_chip *chip) |
| } |
| |
| for_each_set_bit(n, ®, SPRD_EIC_PER_BANK_NR) { |
| - girq = irq_find_mapping(chip->irq.domain, |
| - bank * SPRD_EIC_PER_BANK_NR + n); |
| + u32 offset = bank * SPRD_EIC_PER_BANK_NR + n; |
| + |
| + girq = irq_find_mapping(chip->irq.domain, offset); |
| |
| generic_handle_irq(girq); |
| - sprd_eic_toggle_trigger(chip, girq, n); |
| + sprd_eic_toggle_trigger(chip, girq, offset); |
| } |
| } |
| } |
| -- |
| 2.7.4 |
| |