| From 7692ad3e74014a088d136908b64bb6da6765cc81 Mon Sep 17 00:00:00 2001 |
| From: Valdis Kletnieks <valdis.kletnieks@vt.edu> |
| Date: Wed, 25 Sep 2019 16:45:59 -0700 |
| Subject: [PATCH] kernel/elfcore.c: include proper prototypes |
| |
| commit 0f74914071ab7e7b78731ed62bf350e3a344e0a5 upstream. |
| |
| When building with W=1, gcc properly complains that there's no prototypes: |
| |
| CC kernel/elfcore.o |
| kernel/elfcore.c:7:17: warning: no previous prototype for 'elf_core_extra_phdrs' [-Wmissing-prototypes] |
| 7 | Elf_Half __weak elf_core_extra_phdrs(void) |
| | ^~~~~~~~~~~~~~~~~~~~ |
| kernel/elfcore.c:12:12: warning: no previous prototype for 'elf_core_write_extra_phdrs' [-Wmissing-prototypes] |
| 12 | int __weak elf_core_write_extra_phdrs(struct coredump_params *cprm, loff_t offset) |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~ |
| kernel/elfcore.c:17:12: warning: no previous prototype for 'elf_core_write_extra_data' [-Wmissing-prototypes] |
| 17 | int __weak elf_core_write_extra_data(struct coredump_params *cprm) |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~ |
| kernel/elfcore.c:22:15: warning: no previous prototype for 'elf_core_extra_data_size' [-Wmissing-prototypes] |
| 22 | size_t __weak elf_core_extra_data_size(void) |
| | ^~~~~~~~~~~~~~~~~~~~~~~~ |
| |
| Provide the include file so gcc is happy, and we don't have potential code drift |
| |
| Link: http://lkml.kernel.org/r/29875.1565224705@turing-police |
| Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/kernel/elfcore.c b/kernel/elfcore.c |
| index fc482c8e0bd8..57fb4dcff434 100644 |
| --- a/kernel/elfcore.c |
| +++ b/kernel/elfcore.c |
| @@ -3,6 +3,7 @@ |
| #include <linux/fs.h> |
| #include <linux/mm.h> |
| #include <linux/binfmts.h> |
| +#include <linux/elfcore.h> |
| |
| Elf_Half __weak elf_core_extra_phdrs(void) |
| { |
| -- |
| 2.7.4 |
| |