| From deeaf11e4c18a7afcc7dc224c97083c595b465a2 Mon Sep 17 00:00:00 2001 |
| From: Denis Efremov <efremov@linux.com> |
| Date: Thu, 26 Sep 2019 10:31:38 +0300 |
| Subject: [PATCH] staging: rtl8188eu: fix HighestRate check in |
| odm_ARFBRefresh_8188E() |
| |
| commit 22d67a01d8d89552b989c9651419824bb4111200 upstream. |
| |
| It's incorrect to compare HighestRate with 0x0b twice in the following |
| manner "if (HighestRate > 0x0b) ... else if (HighestRate > 0x0b) ...". The |
| "else if" branch is constantly false. The second comparision should be |
| with 0x03 according to the max_rate_idx in ODM_RAInfo_Init(). |
| |
| Cc: Michael Straube <straube.linux@gmail.com> |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Denis Efremov <efremov@linux.com> |
| Acked-by: Larry Finger <Larry.Finger@lwfinger.net> |
| Link: https://lore.kernel.org/r/20190926073138.12109-1-efremov@linux.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c b/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c |
| index 9ddd51685063..5792f491b59a 100644 |
| --- a/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c |
| +++ b/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c |
| @@ -409,7 +409,7 @@ static int odm_ARFBRefresh_8188E(struct odm_dm_struct *dm_odm, struct odm_ra_inf |
| pRaInfo->PTModeSS = 3; |
| else if (pRaInfo->HighestRate > 0x0b) |
| pRaInfo->PTModeSS = 2; |
| - else if (pRaInfo->HighestRate > 0x0b) |
| + else if (pRaInfo->HighestRate > 0x03) |
| pRaInfo->PTModeSS = 1; |
| else |
| pRaInfo->PTModeSS = 0; |
| -- |
| 2.7.4 |
| |
