| From ef494cd3fab4bfef3e717bc19c1394d4cca1f29a Mon Sep 17 00:00:00 2001 |
| From: David Hildenbrand <david@redhat.com> |
| Date: Fri, 27 Sep 2019 17:46:28 +0200 |
| Subject: [PATCH] xen/balloon: Set pages PageOffline() in balloon_add_region() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| commit c5ad81eb029570c5ca5859539b0679f07a776d25 upstream. |
| |
| We are missing a __SetPageOffline(), which is why we can get |
| !PageOffline() pages onto the balloon list, where |
| alloc_xenballooned_pages() will complain: |
| |
| page:ffffea0003e7ffc0 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 |
| flags: 0xffffe00001000(reserved) |
| raw: 000ffffe00001000 dead000000000100 dead000000000200 0000000000000000 |
| raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 |
| page dumped because: VM_BUG_ON_PAGE(!PageOffline(page)) |
| ------------[ cut here ]------------ |
| kernel BUG at include/linux/page-flags.h:744! |
| invalid opcode: 0000 [#1] SMP NOPTI |
| |
| Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> |
| Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> |
| Fixes: 77c4adf6a6df ("xen/balloon: mark inflated pages PG_offline") |
| Cc: stable@vger.kernel.org # v5.1+ |
| Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Cc: Juergen Gross <jgross@suse.com> |
| Cc: Stefano Stabellini <sstabellini@kernel.org> |
| Signed-off-by: David Hildenbrand <david@redhat.com> |
| Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c |
| index 559768dc2567..8300982b1da1 100644 |
| --- a/drivers/xen/balloon.c |
| +++ b/drivers/xen/balloon.c |
| @@ -691,6 +691,7 @@ static void __init balloon_add_region(unsigned long start_pfn, |
| /* totalram_pages and totalhigh_pages do not |
| include the boot-time balloon extension, so |
| don't subtract from it. */ |
| + __SetPageOffline(page); |
| __balloon_append(page); |
| } |
| |
| -- |
| 2.7.4 |
| |
