| From f99bdf01e231b0b35be3361f13a9d0d44b577e99 Mon Sep 17 00:00:00 2001 |
| From: Markus Elfring <elfring@users.sourceforge.net> |
| Date: Sat, 9 Nov 2019 17:19:35 +0100 |
| Subject: [PATCH] ARM: OMAP2+: Add missing put_device() call in |
| omapdss_init_of() |
| |
| commit 0b491904f053e41685162af5c5411b85b18c97a7 upstream. |
| |
| A coccicheck run provided information like the following. |
| |
| arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device; |
| call of_find_device_by_node on line 258, but without a corresponding |
| object release within this function. |
| |
| Generated by: scripts/coccinelle/free/put_device.cocci |
| |
| Thus add the missed function call to fix the exception handling for |
| this function implementation. |
| |
| Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver") |
| Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> |
| Signed-off-by: Tony Lindgren <tony@atomide.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c |
| index 439e143cad7b..46012ca812f4 100644 |
| --- a/arch/arm/mach-omap2/display.c |
| +++ b/arch/arm/mach-omap2/display.c |
| @@ -265,6 +265,7 @@ static int __init omapdss_init_of(void) |
| r = of_platform_populate(node, NULL, NULL, &pdev->dev); |
| if (r) { |
| pr_err("Unable to populate DSS submodule devices\n"); |
| + put_device(&pdev->dev); |
| return r; |
| } |
| |
| -- |
| 2.7.4 |
| |