| From a3ea28ac3b99e8c9bcef91bba2a8e946801ea8ca Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Thu, 16 Jan 2020 17:07:05 +0100 |
| Subject: [PATCH] USB: serial: suppress driver bind attributes |
| |
| commit fdb838efa31e1ed9a13ae6ad0b64e30fdbd00570 upstream. |
| |
| USB-serial drivers must not be unbound from their ports before the |
| corresponding USB driver is unbound from the parent interface so |
| suppress the bind and unbind attributes. |
| |
| Unbinding a serial driver while it's port is open is a sure way to |
| trigger a crash as any driver state is released on unbind while port |
| hangup is handled on the parent USB interface level. Drivers for |
| multiport devices where ports share a resource such as an interrupt |
| endpoint also generally cannot handle individual ports going away. |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Cc: stable <stable@vger.kernel.org> |
| Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c |
| index 270fb4e2ca1c..320479dec1a3 100644 |
| --- a/drivers/usb/serial/usb-serial.c |
| +++ b/drivers/usb/serial/usb-serial.c |
| @@ -1317,6 +1317,9 @@ static int usb_serial_register(struct usb_serial_driver *driver) |
| return -EINVAL; |
| } |
| |
| + /* Prevent individual ports from being unbound. */ |
| + driver->driver.suppress_bind_attrs = true; |
| + |
| usb_serial_operations_init(driver); |
| |
| /* Add this device to our list of devices */ |
| -- |
| 2.7.4 |
| |
