| From 4487e9c79ad62bc18eb6919aa0cdbacc1dcaddf0 Mon Sep 17 00:00:00 2001 |
| From: Felix Fietkau <nbd@nbd.name> |
| Date: Wed, 8 Jan 2020 18:06:30 +0100 |
| Subject: [PATCH] cfg80211: fix memory leak in cfg80211_cqm_rssi_update |
| |
| commit df16737d438f534d0cc9948c7c5158f1986c5c87 upstream. |
| |
| The per-tid statistics need to be released after the call to rdev_get_station |
| |
| Cc: stable@vger.kernel.org |
| Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info") |
| Signed-off-by: Felix Fietkau <nbd@nbd.name> |
| Link: https://lore.kernel.org/r/20200108170630.33680-2-nbd@nbd.name |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c |
| index 36e6d45b45dd..33105ca1756d 100644 |
| --- a/net/wireless/nl80211.c |
| +++ b/net/wireless/nl80211.c |
| @@ -10669,6 +10669,7 @@ static int cfg80211_cqm_rssi_update(struct cfg80211_registered_device *rdev, |
| if (err) |
| return err; |
| |
| + cfg80211_sinfo_release_content(&sinfo); |
| if (sinfo.filled & BIT_ULL(NL80211_STA_INFO_BEACON_SIGNAL_AVG)) |
| wdev->cqm_config->last_rssi_event_value = |
| (s8) sinfo.rx_beacon_signal_avg; |
| -- |
| 2.7.4 |
| |