| From 60f2581e90d778409f0adf52eefee37d34b0e594 Mon Sep 17 00:00:00 2001 |
| From: Alain Volmat <alain.volmat@st.com> |
| Date: Tue, 12 Nov 2019 09:19:44 +0100 |
| Subject: [PATCH] i2c: i2c-stm32f7: fix 10-bits check in slave free id search |
| loop |
| |
| commit 7787657d7ee55a9ecf4aea4907b46b87a44eda67 upstream. |
| |
| Fix a typo in the free slave id search loop. Instead of I2C_CLIENT_PEC, |
| it should have been I2C_CLIENT_TEN. The slave id 1 can only handle 7-bit |
| addresses and thus is not eligible in case of 10-bit addresses. |
| As a matter of fact none of the slave id support I2C_CLIENT_PEC, overall |
| check is performed at the beginning of the stm32f7_i2c_reg_slave function. |
| |
| Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support") |
| Signed-off-by: Alain Volmat <alain.volmat@st.com> |
| Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com> |
| Signed-off-by: Wolfram Sang <wsa@the-dreams.de> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c |
| index 14eb665cd737..0a0c0191675f 100644 |
| --- a/drivers/i2c/busses/i2c-stm32f7.c |
| +++ b/drivers/i2c/busses/i2c-stm32f7.c |
| @@ -1265,7 +1265,7 @@ static int stm32f7_i2c_get_free_slave_id(struct stm32f7_i2c_dev *i2c_dev, |
| * slave[1] supports 7-bit slave address only |
| */ |
| for (i = STM32F7_I2C_MAX_SLAVE - 1; i >= 0; i--) { |
| - if (i == 1 && (slave->flags & I2C_CLIENT_PEC)) |
| + if (i == 1 && (slave->flags & I2C_CLIENT_TEN)) |
| continue; |
| if (!i2c_dev->slave[i]) { |
| *id = i; |
| -- |
| 2.7.4 |
| |
