| From 7e38e03ed866629cf5493ff17355df002d03daad Mon Sep 17 00:00:00 2001 |
| From: Lorenzo Bianconi <lorenzo@kernel.org> |
| Date: Sat, 21 Sep 2019 10:44:01 +0200 |
| Subject: [PATCH] mt7601u: fix bbp version check in mt7601u_wait_bbp_ready |
| |
| commit 15e14f76f85f4f0eab3b8146e1cd3c58ce272823 upstream. |
| |
| Fix bbp ready check in mt7601u_wait_bbp_ready. The issue is reported by |
| coverity with the following error: |
| |
| Logical vs. bitwise operator |
| The expression's value does not depend on the operands; inadvertent use |
| of the wrong operator is a likely logic error. |
| |
| Addresses-Coverity-ID: 1309441 ("Logical vs. bitwise operator") |
| Fixes: c869f77d6abb ("add mt7601u driver") |
| Acked-by: Jakub Kicinski <kubakici@wp.pl> |
| Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org> |
| Signed-off-by: Kalle Valo <kvalo@codeaurora.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/net/wireless/mediatek/mt7601u/phy.c b/drivers/net/wireless/mediatek/mt7601u/phy.c |
| index 06f5702ab4bd..d863ab4a66c9 100644 |
| --- a/drivers/net/wireless/mediatek/mt7601u/phy.c |
| +++ b/drivers/net/wireless/mediatek/mt7601u/phy.c |
| @@ -213,7 +213,7 @@ int mt7601u_wait_bbp_ready(struct mt7601u_dev *dev) |
| |
| do { |
| val = mt7601u_bbp_rr(dev, MT_BBP_REG_VERSION); |
| - if (val && ~val) |
| + if (val && val != 0xff) |
| break; |
| } while (--i); |
| |
| -- |
| 2.7.4 |
| |
