| From c1e565518a9be510011ecd8e1431a12e54e369f2 Mon Sep 17 00:00:00 2001 |
| From: Alexander Lobakin <alobakin@dlink.ru> |
| Date: Wed, 15 Jan 2020 11:56:52 +0300 |
| Subject: [PATCH] net: dsa: tag_qca: fix doubled Tx statistics |
| |
| commit bd5874da57edd001b35cf28ae737779498c16a56 upstream. |
| |
| DSA subsystem takes care of netdev statistics since commit 4ed70ce9f01c |
| ("net: dsa: Refactor transmit path to eliminate duplication"), so |
| any accounting inside tagger callbacks is redundant and can lead to |
| messing up the stats. |
| This bug is present in Qualcomm tagger since day 0. |
| |
| Fixes: cafdc45c949b ("net-next: dsa: add Qualcomm tag RX/TX handler") |
| Reviewed-by: Andrew Lunn <andrew@lunn.ch> |
| Signed-off-by: Alexander Lobakin <alobakin@dlink.ru> |
| Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c |
| index c95885215525..c8a128c9e5e0 100644 |
| --- a/net/dsa/tag_qca.c |
| +++ b/net/dsa/tag_qca.c |
| @@ -33,9 +33,6 @@ static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev) |
| struct dsa_port *dp = dsa_slave_to_port(dev); |
| u16 *phdr, hdr; |
| |
| - dev->stats.tx_packets++; |
| - dev->stats.tx_bytes += skb->len; |
| - |
| if (skb_cow_head(skb, 0) < 0) |
| return NULL; |
| |
| -- |
| 2.7.4 |
| |
